Skip to content

Warn only about unusual targets, naming the reason, 1.2.1 - #26

Merged
NitroDiesel merged 1 commit into
mainfrom
honest-device-warning
Nov 13, 2026
Merged

NitroDiesel merged 1 commit into
mainfrom
honest-device-warning

Conversation

@NitroDiesel

Copy link
Copy Markdown
Owner

The device picker showed " is not ordinary removable media. Check the target before writing." for an ordinary Kingston USB flash drive. Any mounted volume triggered it. On Windows every stick with a drive letter has one, and so does a desktop-automounted stick on Linux. Mounted volumes are expected: the engine unmounts or dismounts them before writing.

The warning now comes from state::device_warning. It appears only for an internal disk, an external hard disk or SSD, or a drive Rufust refuses (system, boot, swap/page file, RAID/LVM/multi-disk member, read-only, no usable identity), and names the reason. Safety checks and confirmations are unchanged. Tests cover a mounted stick (no warning) and each kind of warning. This PR also releases the fix as 1.2.1.

🤖 Generated with Claude Code

The device picker called any drive with a mounted volume "not ordinary
removable media". On Windows every USB stick with a drive letter has one,
and so does a desktop-automounted stick on Linux, so ordinary flash drives
were flagged. Mounted volumes are expected: the engine unmounts or
dismounts them before writing.

The warning now appears only for an internal disk, an external hard disk
or SSD, or a drive Rufust refuses, and says which. Release as 1.2.1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NitroDiesel
NitroDiesel merged commit b16a9bd into main Nov 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant