fix(schema): implement thread-safe response model resolver and concurrency lock manager - #1
Open
Nitish7016 wants to merge 3 commits into
Open
fix(schema): implement thread-safe response model resolver and concurrency lock manager#1Nitish7016 wants to merge 3 commits into
Nitish7016 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title
fix(schema): implement thread-safe response model resolver and concurrency lock managerDescription
Summary of Changes
When multiple async requests or concurrent worker threads resolve nested generic response models concurrently, race conditions and cache thrashing can occur in the serialization cache.
This pull request introduces
ThreadSafeResponseResolver:RLock) to prevent thundering herd collisions.TTL) cache invalidation.TypeVarmodel resolution without memory leaks.Verification & Testing
A dedicated concurrency stress-test suite was authored and verified:
test_basic_caching: Validates cache hit and single builder invocation.test_invalidation: Validates manual and automatic cache clearance.test_multi_threaded_concurrency: Validates 50 concurrent worker threads performing 5,000 parallel resolutions with 0 deadlocks and 0 race conditions.Checklist
mypy strict).