Skip to content

Replace hardcoded CJK font paths with egui-system-fonts crate - #1

Open
NimitzDEV wants to merge 1 commit into
mainfrom
replace-hardcoded-fonts-with-egui-system-fonts-4947503900392803775
Open

NimitzDEV wants to merge 1 commit into
mainfrom
replace-hardcoded-fonts-with-egui-system-fonts-4947503900392803775

Conversation

@NimitzDEV

Copy link
Copy Markdown
Owner

This PR removes the hardcoded CJK font paths and replaces them with an automated approach using the egui-system-fonts crate, as requested. The application will now dynamically detect and load available system fonts for rendering UI text safely across platforms.


PR created automatically by Jules for task 4947503900392803775 started by @NimitzDEV

- Added `egui-system-fonts` version 0.36.0 to dependencies in `Cargo.toml`.
- Replaced manual font loading in `src/ui/app.rs` with `egui_system_fonts::set_auto`.
- Removed fragile, OS-specific hardcoded font paths (Windows, macOS, Linux).

Co-authored-by: NimitzDEV <7098462+NimitzDEV@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant