Repository navigation
fix: default ReportingCondition to succeeded(), not true - #82
Merged
Merged
Conversation
Review caught that the literal true default replaced the download/ reportgenerator/run-count/coverage steps' previous implicit succeeded() condition, so an earlier step failure (e.g. a failed download, or CheckForFailedTests erroring before setting its output vars) no longer skipped the rest of the cascade - it ran against missing data instead, and the run-count check specifically crashed on an unexpanded $(CheckForFailedTests.CompletedTestRunCount) macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collate-test-results.yml's newReportingConditionparameter defaulted to the literaltrueinstead ofsucceeded(), silently dropping the download/reportgenerator/run-count/coverage steps' previous implicit fail-fast: an earlier step failure (e.g. a failed download, orCheckForFailedTestserroring before setting its output vars) no longer skipped the rest of the cascade — it ran against missing data instead, and the run-count check specifically crashed on an unexpanded$(CheckForFailedTests.CompletedTestRunCount)macro.succeeded(), matching these steps' pre-existing behavior before feat!: repoint collate-test-results.yml for grahamandtonic's full repoint #81.Test plan
python -c "import yaml; yaml.safe_load(...)"— parses cleanly