Repository navigation
APP-569: Upgrade pnpm 11 to pnpm 12 - #24989
Open
charliegilman wants to merge 5 commits into
Open
charliegilman wants to merge 5 commits into
charliegilman wants to merge 5 commits into
Conversation
Pin pnpm 12.21.0 via pnpm self-update. The lockfile change is only pnpm's own pin: packageManagerDependencies now records pnpm 12's per-platform native binaries instead of @pnpm/exe 11. No dependency versions moved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pnpm/setup v2 cannot install pnpm 12; v3.2.0 can. publish-vortex-api.yml had its own pnpm/action-setup + setup-node + node-gyp chmod workaround, so it now uses the shared setup-pnpm action too and keeps setup-node only to write the npm registry config for trusted publishing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test hard-coded winapi-bindings' node_modules/.pnpm folder name, which pnpm 12 hashes differently, so the native cross-check silently skipped. Resolve it through @vortex/main instead and fail rather than skip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
.node-version said 22 while the repo pins Node 24.22.3 through devEngines.runtime; nothing reads it. Also drop the shared setup docs' claim of a Node catalog entry that does not exist, and bump the pnpm version suggested to extension authors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workflow always built the release tag, so a pnpm upgrade could not be dry-run before release. An optional ref input builds that branch or commit instead, and a guard refuses a real publish with it set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
charliegilman
marked this pull request as ready for review
November 19, 2026 16:51
Contributor
Author
|
@Sewer56 could you check this on NixOS if you get a minute please? The repo now pins On this branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves APP-569.
Summary
packageManagerDependencies). No dependency versions moved. pnpm accepted the existing lockfile without re-resolving, so pnpm 12's one-time rewrite of cyclic peer variants hasn't happened yet. It will show up in whichever PR next re-resolves dependencies.allowBuildsstill matches under pnpm 12. On a clean install,winapi-bindings,lootanddrivelistwere built from their git tarballs.globalShimson, and hardlink-first package import on Linux.Evidence
On Windows I ran the steps from
.github/actions/package/action.yml(unsigned) on master with pnpm 11.10.0, then on this branch with pnpm 12.21.0, and diffed the outputs.src/main/distfile list, injected workspace packages (files andexports)win-unpackedfiles,app.asar.unpackedverify-packaged-asar.mjsvortex-api:pnpm version(as CI runs it),packfile list, packedpackage.jsonvortex-api:pnpm publish --dry-run --access public --tag betaetc/Dependency Report.md(pnpm list --json)package.jsondependency versions2.1.3(electron@45.3.4); pnpm 12 writes2.1.3.prepare-dist-package.mjspasses both through unchangednode_modulesin the deploy (and soapp.asar)chownr,lru-cache,undici,jackspeak) a different version is hoisted to the top@emnapi/*in the deploy@rolldown/binding-wasm32-wasi, which is wasm32-only and never installedassets/bom.json(pnpm sbom)pnpm run verifypasses (format, build with lint and typecheck, and 175 test tasks). E2E not run.Both release pipelines were also run in CI against this branch, and neither published anything:
.github/actions/packagepath (unsigned) under pnpm 12.21.0. It ended withchecked 193 nested packages, 0 version mismatch(es)and builtvortex-setup-1.0.0-nightly.20261119.exe. The output was uploaded only as artifacts.refinput with tagv0.0.0-pnpm12test.0anddry-run=true. It ran the version bump, a frozen install, the build, andpnpm publish --provenance --access public --tag beta --dry-run, fetched the OIDC token for npm, and ended withSkip publishing @nexusmods/vortex-api@0.0.0-pnpm12test.0 (dry run). Afterwardsnpm viewreturns 404 for that version, and the dist-tags are unchanged (latest: 2.11.0,beta: 2.11.0-beta.5).To make that dry run possible,
publish-vortex-api.ymlgains an optionalrefinput that builds a branch instead of the tag. A guard step fails any run that setsrefwithoutdry-run, so a branch can never be published under a release version.The publish step logs
[WARN] Failed to replace env in config: ${NODE_AUTH_TOKEN}. That comes from the.npmrcthatsetup-nodewrites; trusted publishing doesn't use the token, and the OIDC exchange went ahead. Linux CI on this PR confirms the hardlinked store and native-module cache paths.Merge Danger
Door: two-way
Reverting the commits restores pnpm 11. Nothing outside the repo changes.
Blast Radius: tooling
Every CI job and contributor install goes through the new pnpm. The installer is built from a deploy whose hoisted layout differs as described above, and
verify-packaged-asarguards against that going wrong. NixOS contributors getpnpmunpinned from nixpkgs, and that pnpm switches itself to the downloaded 12.21.0 binary. I couldn't test that here, so it needs a check from someone on NixOS.Follow-ups, not in this PR:
development→./src/*.tsexports.publishConfig.exportsis not applied whenpnpm deployinjects them. That's the same on pnpm 11, so it isn't a regression.