Repository navigation
Merged
Conversation
Contributor
Author
|
Added e5849e2: the Properties panel now uses our tooltip component instead of native
|
…755) A mod that was never enabled showed Enabled as 56 years ago.
…ers for outside images (LAZ-1755) The Properties panel's card links to the mod's page, found as the Advanced tab's game section is.
…its fields (LAZ-1755) Tabs over a fading scroll area, a resizable full-width notes box, more room round the empty state, no Downloaded badge.
…e (LAZ-1755) The columns scroll sideways clear of it when both don't fit; the grid role moves to a display: contents wrapper, outside which the panel sits.
…roll-state query (LAZ-1755) Reaching either end then restyles only the rules that use it.
…page's (LAZ-1755)
…aside (LAZ-1755) The click handler goes back on the laid-out element; keyboard resizing stops short of the aside; a shut last group's heading counts as the last row.
A scroll, vertical ones included, now reads only how far left it is.
…d keep its focus rings whole (LAZ-1755)
…game (LAZ-1755) Shares nexus_integration's mod page lookup, which falls back to a game's own id, as Stardew Valley's is.
…anage categories (LAZ-1755) The card links to the mod's kept homepage; the last row's shadow strip, tab scroll reset and resizer measure fixes. Table toolbar padding matches the page header's; the categories action is called Manage categories.
…Z-1755) Times show their full date and buttons their names in the tooltip; the dropdowns, version, ids and collections go without one.
…cutting them short (LAZ-1755) An archive name or path now shows whole, so it needs no tooltip.
Contributor
Author
|
Rebased onto Added 6cecd2e: long values in the Properties panel, like the archive name or a deploy path, now wrap to show in full instead of being cut short with a tooltip. Paths and file names with no spaces break where they need to. The copy buttons keep their tooltip, and the times keep theirs for the full date. |
ecemooo
reviewed
Nov 19, 2026
useScrollableRight clears its mark on cleanup; keptSection moves back into useModAdvancedEdits; a long comment rewrapped.
ecemooo
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves LAZ-1755.
Fixes and polish for the new Mods table and its Properties panel.
What changes
Properties panel
homepage). Nothing is tracked.Panel over the table
Shared
TabletoolbarOverhangis replaced byasideandasideWidth. The aside is a sticky grid item, and therole="grid"moves to an innerdisplay: contentswrapper, so the panel shares the layout but isn't part of the grid. A click on the aside doesn't clear the table's selection; one on the table's empty space still does.@container scroll-state(scrollable: right)is replaced by adata-scrollable-rightattribute thatuseScrollableRightsets on change. Reaching either end of a sideways scroll then restyles only what uses it. In a trace, the work at each end roughly halved.--nxm-table-end-padding, inside the table, so things pinned over it reach its foot. A strip under the rows carries the sticky column's shadow through it, without any row's tint.Other
modsTable::properties::manageCategoriesadded;hideDescriptionandcloseremoved.useModAdvancedEditstoutil/kept_section, unchanged.Testing
Typecheck passes, and the renderer tests for the table, mod management, Nexus integration and categories pass. I checked the changes in the dev app through DevTools, including the accessibility tree and that rows are still virtualized, except the last round (homepage links, the shadow strip under the last row, the tab-switch scroll reset), which only the tests cover.
pnpm run verifyand E2E not run.The screenshots were taken before the panel's close button was removed and Manage categories was added.
Panel over table
Scrolled to last columns
Panel tabs fixed and fade
Description modal
Bottom of table
Selection bar
Empty state