Skip to content

Polish the new Mods table's Properties panel, and pin it over the table when space is short - #24983

Merged
r1chm8 merged 14 commits into
masterfrom
laz-1755
Nov 19, 2026
Merged

r1chm8 merged 14 commits into
masterfrom
laz-1755

Conversation

@r1chm8

@r1chm8 r1chm8 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Resolves LAZ-1755.

Fixes and polish for the new Mods table and its Properties panel.

What changes

Properties panel

  • The tabs (or several mods' count) stay at the top while the contents scroll. The contents fade out at the bottom, with room to scroll clear of the fade, as on Browse's mod details. Switching tabs starts the new tab at its top, and the header leaves room for the tabs' focus rings.
  • The scroll area reserves its scrollbar's room, so the contents don't re-wrap when a scrollbar appears. The scrollbar sits 6px in from the page's.
  • Show description is an outlined button that opens the full description in a modal. Images from outside Nexus Mods show the same placeholders as Browse, linking to the mod's page as Vortex kept it on download (homepage). Nothing is tracked.
  • Notes is a full-width text area, three lines tall, that the user can resize.
  • The empty state has more room around it, and the card no longer shows a Downloaded badge. Update available still shows.
  • Enabled no longer reads "56 years ago" for a mod that was never enabled.
  • The panel has no close button of its own: the toolbar's Properties button opens and closes it.
  • An outlined Manage categories button beside Category opens the categories dialog, with the toolbar's tag icon. The toolbar action is renamed to Manage categories to match, which the classic Mods page shares.

Panel over the table

  • When the table and panel don't fit side by side, the panel sits over the table's right edge and the table scrolls sideways, so every column can be reached. Actions stays pinned beside the panel. When there's room, nothing changes.
  • The toolbar buttons above the panel stay clickable while the rows scroll.
  • The divider and the Actions column's shadow fade in at the top and reach the bottom of the page. The selection bar has a square corner where it meets the panel.
  • The table toolbar's right padding matches the page header's, so their last buttons line up. The rule is shared, so the plan page's table toolbar moves too.

Shared Table

  • toolbarOverhang is replaced by aside and asideWidth. The aside is a sticky grid item, and the role="grid" moves to an inner display: contents wrapper, so the panel shares the layout but isn't part of the grid. A click on the aside doesn't clear the table's selection; one on the table's empty space still does.
  • @container scroll-state(scrollable: right) is replaced by a data-scrollable-right attribute that useScrollableRight sets on change. Reaching either end of a sideways scroll then restyles only what uses it. In a trace, the work at each end roughly halved.
  • The table's bottom margin is now --nxm-table-end-padding, inside the table, so things pinned over it reach its foot. A strip under the rows carries the sticky column's shadow through it, without any row's tint.
  • Keyboard column resizing stops short of the aside.

Other

  • Strings: modsTable::properties::manageCategories added; hideDescription and close removed.
  • The Advanced tab's game-section lookup moved from useModAdvancedEdits to util/kept_section, unchanged.

Testing

Typecheck passes, and the renderer tests for the table, mod management, Nexus integration and categories pass. I checked the changes in the dev app through DevTools, including the accessibility tree and that rows are still virtualized, except the last round (homepage links, the shadow strip under the last row, the tab-switch scroll reset), which only the tests cover. pnpm run verify and E2E not run.

The screenshots were taken before the panel's close button was removed and Manage categories was added.

Panel over table

1-panel-over-table

Scrolled to last columns

2-scrolled-to-last-columns

Panel tabs fixed and fade

3-panel-tabs-fixed-and-fade

Description modal

4-description-modal

Bottom of table

5-bottom-of-table

Selection bar

6-selection-bar

Empty state

7-empty-state

@r1chm8 r1chm8 self-assigned this Nov 19, 2026
@r1chm8
r1chm8 marked this pull request as ready for review November 19, 2026 12:51
@r1chm8
r1chm8 requested a review from a team as a code owner November 19, 2026 12:51
@r1chm8

r1chm8 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Added e5849e2: the Properties panel now uses our tooltip component instead of native titles.

  • Times (Installed, Downloaded, Enabled) show the full date and time on hover, formatted as Browse's mod card does.
  • Buttons (Manage categories, copy, Open website) have their name in a tooltip, and keep it as their accessible name.
  • No title at all on the dropdowns, the version, the ids or the collections, where it only repeated what was already shown. Long values like the archive name keep theirs.

…755)

 A mod that was never enabled showed Enabled as 56 years ago.
…ers for outside images (LAZ-1755)

 The Properties panel's card links to the mod's page, found as the Advanced tab's game section is.
…its fields (LAZ-1755)

 Tabs over a fading scroll area, a resizable full-width notes box, more room round the empty state, no Downloaded badge.
…e (LAZ-1755)

 The columns scroll sideways clear of it when both don't fit; the grid role moves to a display: contents wrapper, outside which the panel sits.
…roll-state query (LAZ-1755)

 Reaching either end then restyles only the rules that use it.
…aside (LAZ-1755)

 The click handler goes back on the laid-out element; keyboard resizing stops short of the aside; a shut last group's heading counts as the last row.
 A scroll, vertical ones included, now reads only how far left it is.
…game (LAZ-1755)

 Shares nexus_integration's mod page lookup, which falls back to a game's own id, as Stardew Valley's is.
…anage categories (LAZ-1755)

The card links to the mod's kept homepage; the last row's shadow strip, tab scroll reset and resizer measure fixes.
Table toolbar padding matches the page header's; the categories action is called Manage categories.
…Z-1755)

Times show their full date and buttons their names in the tooltip; the dropdowns, version, ids and collections go without one.
…cutting them short (LAZ-1755)

An archive name or path now shows whole, so it needs no tooltip.
@r1chm8

r1chm8 commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto master and force-pushed, so the commit hashes have changed.

Added 6cecd2e: long values in the Properties panel, like the archive name or a deploy path, now wrap to show in full instead of being cut short with a tooltip. Paths and file names with no spaces break where they need to. The copy buttons keep their tooltip, and the times keep theirs for the full date.

useScrollableRight clears its mark on cleanup; keptSection moves back into useModAdvancedEdits; a long comment rewrapped.
@r1chm8
r1chm8 enabled auto-merge November 19, 2026 14:19
@r1chm8
r1chm8 merged commit 56fd160 into master Nov 19, 2026
13 checks passed
@r1chm8
r1chm8 deleted the laz-1755 branch November 19, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants