Repository navigation
Conversation
…emaining context warnings (LAZ-1698)
ecemooo
marked this pull request as ready for review
November 19, 2026 12:02
r1chm8
reviewed
Nov 19, 2026
…on MainContext (LAZ-1698)
r1chm8
previously approved these changes
Nov 19, 2026
r1chm8
left a comment
Contributor
There was a problem hiding this comment.
Thanks, all the earlier points check out. One small typing note inline, not blocking.
r1chm8
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/nexus-mods/issue/LAZ-1698/clear-the-react-deprecation-warnings-out-of-the-renderer-tests
Summary
Our components stop using React's legacy context, which React 19 removes.
ComponentExand the classes that declared their own context now readMainContext, which holds the sameapi,menuLayerandgetModifiers, so thethis.contextreads across the app don't change. Nothing changes for users.OverlayTriggerdraws its overlay as a separate React root, whichMainContextdoesn't reach.MainContextOverlayTriggerhands the overlay its trigger'sMainContext, so a menu in a popover in a dialog opens above the dialog. OurOverlayTrigger,TooltipControlsand the changelog button use it. Anywhere else,MainProviderfills inMainContext's default value, so an overlay still gets the app'sapi.Modalpasses its own menu layer down throughMainContext, so menus opened in a dialog still sit above it.ComponentEx.contextTypes, andComponentExsubclasses that declarecontextTypesof their own.<p>inside a<p>in Game details, BBCode tables without a<tbody>, and a test mock that couldn't take a ref.FormFeedbackkeeps legacy context: it reads react-bootstrap'sFormGroup, which has no other way to share it.Evidence
After: 30. The rest are
findDOMNodeanddefaultProps(the other LAZ-1698 PRs fix those) and react-bootstrap's own. All renderer tests pass.Merge Danger
Door: two-way. Reverting brings back legacy context.
Blast Radius: wide. Every class component built on
ComponentExgets its context a new way. If one ended up with noMainContextvalue, it would have noapi. Watch for menus in dialogs, overlays and popovers, and extension UIs.For extension authors: a menu inside a popover from react-bootstrap's own
OverlayTrigger, inside a dialog, now opens behind the dialog. Nothing in the repo does this.