Repository navigation
Invite logged-out users to log in with a new login dialog, behind an Unleash experiment (STA-574) - #24969
Open
rjp-coder wants to merge 1 commit into
Open
Invite logged-out users to log in with a new login dialog, behind an Unleash experiment (STA-574)#24969rjp-coder wants to merge 1 commit into
rjp-coder wants to merge 1 commit into
Conversation
|
This PR has conflicts. You need to rebase the PR before it can be merged. |
rjp-coder
force-pushed
the
ryanparry-sta-574
branch
from
November 19, 2026 15:27
4352946 to
45aa6af
Compare
|
This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed. |
…Unleash experiment (STA-574) The `vortex-sta-574-login-prompt` flag splits installs into `test` and `control`. With the flag off, as in production until it's switched on, everyone is `control` and nothing changes. `test` gets: - a startup modal for logged-out users, from the Figma, with "No, thanks", "Log in to Vortex" and a "Don't show this again" tickbox. It has no X and only closes with an answer; either answer saves the tickbox through the suppressed notifications. - a redesigned `login-dialog` on every route (header, Health Check, `ensureLoggedIn`): the Figma progress view, a token fallback, and a start view. Login buttons no longer open it first, so it goes straight to the progress view; clicks outside it don't cancel the login. `control` keeps the old dialog and flow. The cohort is fixed for the session at the first decision the user would see, so the modal and the dialog agree even if flags arrive late. Adds an `account` pictogram. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rjp-coder
force-pushed
the
ryanparry-sta-574
branch
from
November 19, 2026 17:01
a8f26ef to
42ce310
Compare
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of STA-574, split into three PRs:
app_login_completed), stacked on this one.Closes STA-574.
When Vortex starts and the user isn't logged in, a modal now invites them to log in, following the Figma design. The login dialog itself is redesigned to match.
Shipped as an Unleash experiment, so we can measure whether they bring in more logins before deciding to keep them.
The experiment
Unleash flag
vortex-sta-574-login-promptsplits installs into two cohorts:testcohort (flag on)controlcohort (flag off)ensureLoggedIngetFlagcall, so Unleash counts one evaluation per session rather than one per re-render.control.nexus_integration/experiments/. See "Ending the experiment" below.Before switching the flag on in production: merge #24991. Without it, a logged-out install falls back to Unleash's per-launch
sessionIdand would change cohort every launch. That PR also covers the Unleash setup.The startup modal
settings.notifications.suppress["login-prompt"]), so Settings → Interface → "Reset suppressed notifications" brings it back.api.showDialogones.account, the Figma's variant of the web'suserpictogram.The new login dialog (
testcohort)login-dialogid. Health Check, the classic header andensureLoggedIncallers (nxm links, profiles, and extensions such as Stardew Valley and BepInEx) all open it, so it couldn't be deleted.Ending the experiment
nexus_integration/experiments/.showLoginPromptOnStartup.ts: the cohort check;useNexusLogin.hook.ts: opening the old dialog first forcontrol;loginTracker.ts(from Count Vortex logins by source with app_login_completed (STA-574) #24990):login_prompt_cohorton the event.index.tsx, register the winning dialog aslogin-dialog.views/LoginDialog.tsx;controls/CopyClipboardInput.tsx;controls/PlaceholderTextArea.tsx;vortex/dialog-login.scss, and its import instyle.scss.unleash/experimentCohort.ts, its call inApplication.ts, and the setter and property inunleash/client.ts.flags.ts.Not in this PR
control(client.ts).Testing
Unit tests cover:
Typecheck and lint pass. E2E was not run.
Tested live in a dev build, before the experiment gate was added, so every launch got the new flow. Browser launches were blocked or simulated, so no real login took place.
The cohort split was then tested live with the flag in the development Unleash environment:
control(flag off): no modal on a logged-out start. The header button opens the old dialog and old progress view, unchanged from master.test(flag on): the modal, its "No, thanks" and tickbox rules, and the new dialog's progress and token views all behave as in the table above.Open Logged Out Before
Open Logged Out After
Login Progress After
Log In With Token After
Control Cohort (Old Dialog, Unchanged)
🤖 Generated with Claude Code