fix: download plugin to temp file first, then atomically replace - #15
Merged
Conversation
Previously the download wrote directly to the target JAR file. If the server restarted or crashed during the download, the plugin would be corrupted (half-written JAR). Now we write to a .tmp file first, and only after a successful download do an atomic move to the target path. On failure the temp file is cleaned up, leaving the original plugin intact.
Owner
|
Looks great, thanks! |
Validate downloaded JARs, preserve existing plugins on every failure, clean up unique temporary files, and run regression tests in CI. Co-authored-by: Molean <cnmolean@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the download wrote directly to the target JAR file. If the server restarted or crashed during the download, the plugin would be corrupted (half-written JAR). Now we write to a .tmp file first, and only after a successful download do an atomic move to the target path. On failure the temp file is cleaned up, leaving the original plugin intact.