Fix for Hilbert phase computation and visualization - #123
Open
cosimolupo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hilbert transform is used for trigger detection, computed over the whole signal passed via the
--dataCLI argument. However, when moving to the visualization part, for the selected channel(s), Hilbert phase is recomputed again, over the (possibly restricted) interval [plot_tstart,plot_tstop], and eventually plotted. This implies visualizing a wrong Hilbert phase, different from the one actually computed at the beginning of the script and used for trigger detection.This PR fixes such bug, plotting the same Hilbert-phase full signal used for trigger detection. In addition, it imporves the visualization itself, by removing a useless zscoring of the signal.