ci: fix Contracts CI dbus dependency and add main branch protection - #1337
Merged
Merged
Conversation
… lib breaks Closes Netwalls#1334
…atus checks Closes Netwalls#1335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci: fix Contracts CI dbus dependency and add main branch protection
What was solved
#1334 — Contracts CI broken on main: missing dbus-1 system lib breaks cargo install stellar-cli
Fix the Contracts CI failure caused by the missing
dbus-1system library whencargo install stellar-clibuildslibdbus-syson Linux runners. Add a step to installlibdbus-1-devandpkg-configbefore installingstellar-cliin the Contracts CI workflow.Addressed:
libdbus-1-devandpkg-config) on the runner beforestellar-cliis installed in the Contracts CI workflow..github/workflows/contracts-ci.yml); do not modify backend, frontend, or other unrelated workflows.#1335 — main branch has no branch protection / required status checks
Add branch protection configuration for the
mainbranch so that PRs require review and the Frontend CI and Contracts CI status checks must pass before merging, and force-pushes/branch deletion are disallowed. Since GitHub branch protection is a repository setting (not code), the scope-faithful contribution is to add a declarative configuration file (e.g. a.github/branch-protection.ymlor documented config) plus a small workflow/script that applies it viagh api, matching the existing.github/workflows/*conventions.Addressed:
mainrequiring pull request review before merging.main.Changes
.github/workflows/backend-ci.yml(modify).github/workflows/contracts-ci.yml(modify).github/workflows/frontend-ci.yml(modify)Approach
Issues
Closes #1334
Closes #1335