Repository navigation
Add market sort/pagination, frontend CI updates, and visual regression tests - #1321
Merged
Ehonrie merged 5 commits intoSep 28, 2026
Merged
Conversation
…book build Closes Netwalls#1297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add market sort/pagination, frontend CI updates, and visual regression tests
What was solved
#1282 — F-64: Sort options for market list
Add sort options (fight date, pool size, newest) to the market list by introducing a URL-synced sort dropdown in MarketFilterBar and threading the selected sort through useMarkets into the API query params.
Addressed:
#1283 — F-65: Paginate / infinite-scroll the market list
Add pagination/infinite scroll to the frontend market list so MarketList no longer renders every market at once. Implement IntersectionObserver-based 'load more' in MarketList, extend useMarkets to support paged fetching that respects active filters and sort, and show a bottom loading indicator.
Addressed:
#1297 — F-79: Frontend CI: run on main, add lint and Storybook build
Update the frontend CI workflow so it also triggers on pushes to main, runs the frontend lint script, builds Storybook, and caches npm dependencies keyed on the lockfile. This is a focused CI configuration change limited to .github/workflows/frontend-ci.yml.
Addressed:
pushtrigger for themainbranch to the workflow'son:block (keep existing triggers such as pull_request).npm run lintin the frontend job.npm run build-storybook).#1298 — F-80: Visual regression tests for core components
Add visual regression coverage for the core frontend components (MarketCard, BettingInterface, FighterCard) by setting up Storybook test-runner/Chromatic, providing light and dark snapshots for each component, and documenting the snapshot update workflow.
Addressed:
Changes
frontend/components/MarketFilterBar.tsx(modify)hooks/useMarkets.ts(create)frontend/components/MarketList.tsx(modify).github/workflows/frontend-ci.yml(modify)frontend/package.json(modify)README.md(modify)Approach
Issues
Closes #1282
Closes #1283
Closes #1297
Closes #1298