fix: new Layout for phonebook section#161
Merged
Merged
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
tommaso-ascani
left a comment
tommaso-ascani
left a comment
Collaborator
There was a problem hiding this comment.
Review — phonebook visibility (public / private / group)
Solid PR overall: visibility logic is well isolated in src/shared/phonebook.ts, validated both in the form and in the API layer, and the checkForUpdate try/catch is a good crash fix. A few things to confirm or fix before merge — details inline.
Main points to confirm:
- The new permission gating can silently block contact creation for
phonebook_level_0users and restrictlevel_1users to private only — is this the intended server-aligned behavior (issue #7123)? privacyis no longer sent in thecreateContactpayload — confirm the backend doesn't rely on it.
Concrete issues: translation files diverge, comma-in-group-name breaks the serialize/deserialize round-trip, and group permission-id normalization can collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference