Repository navigation
Skip id normalization for existing meters - #1299
Merged
Merged
Conversation
DanielThomas
marked this pull request as ready for review
September 22, 2026 07:28
brharrington
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running some profiles against Images and Supermarket and found that
Idnormalisation was a hotspot. Avoiding this work should give a small but noticeable improvement to CPU utilisation from Spectator.Benchmark
JDK 25, one thread, two forks:
Allocation is unchanged: 40 B/op for valid lookups and 304 B/op for the invalid-id normalization path. The allocation is the
SwapCounterreturned from each registry lookup plus, for the invalid case, the normalized id.