Repository navigation
Conversation
- Replace the invalid `ALTER TABLE metadata_v3 DROP metadata_v3 metadata_v3_akey` in the Down block of 20201002000616_update_metadata_primary_key.sql with `DROP INDEX metadata_v3_akey`; the syntax error made rolling back past this migration impossible - Add a migration service integration test that applies all migrations, resets to version 0 and applies them again - Run goose against a dedicated `migration_test` schema via `search_path` so the rollback never touches tables used by the other integration tests Relates to Netflix#269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALTER TABLE metadata_v3 DROP metadata_v3 metadata_v3_akeyin the Down block of 20201002000616_update_metadata_primary_key.sql withDROP INDEX metadata_v3_akey; the syntax error made rolling back past this migration impossiblemigration_testschema viasearch_pathso the rollback never touches tables used by the other integration testsFIxes #269