fix(review-pr): always leave a final verdict when no issues found - #98
Open
grushikhin wants to merge 1 commit into
Open
fix(review-pr): always leave a final verdict when no issues found#98grushikhin wants to merge 1 commit into
grushikhin wants to merge 1 commit into
Conversation
The review posts via claude-code-action with track_progress + sticky comment. The 'no issues -> do not post any comments' instruction left the sticky comment stuck on the interim 'I'll analyze this and get back to you' placeholder, so clean PRs showed no visible result. Instruct the reviewer to finish with a short verdict (e.g. 'Reviewed — no issues found') in the sticky comment, clarified as the tracking comment (not a separate review report).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/review-prskill runs viaclaude-code-actionwithtrack_progress: true+use_sticky_comment: true(seedevops/.github/actions/agent-review). When a PR is clean, the skill said:So the reviewer posted nothing, and the sticky progress comment stayed stuck on the interim "I'll analyze this and get back to you" placeholder. Reviewers/authors saw a finished-but-empty comment and couldn't tell the PR was actually reviewed and clean.
Observed on
cloudbankin-data-exportPR #258 (dev→master): review ran all 6 agents,No buffered inline comments, but the sticky comment never got a verdict.Fix
Change the "no issues" instruction: still no inline comments, but always end with a short final verdict in the sticky comment (e.g.
✅ Reviewed — no issues found.), clarified as the tracking/sticky comment rather than a separate overall review report (so it doesn't conflict with the "inline comments only" rule).Scope: only
review-pr(it posts to the PR).review-local-changesis unchanged — it reports locally and has no sticky comment.