Adding an Interact hotkey.#5364
Open
MistakeNot4892 wants to merge 1 commit into
Open
Conversation
MistakeNot4892
force-pushed
the
tweak/interact_key
branch
from
May 16, 2026 05:01
901fc03 to
e53a9e4
Compare
MistakeNot4892
force-pushed
the
tweak/interact_key
branch
from
May 22, 2026 03:28
e53a9e4 to
b425a19
Compare
out-of-phaze
requested changes
Jun 27, 2026
out-of-phaze
left a comment
out-of-phaze
left a comment
Member
There was a problem hiding this comment.
seems good except for some nitpicks
Comment on lines
+205
to
+211
| var/list/atoms = sortTim(facing.contents.Copy(), /proc/cmp_planelayer) | ||
|
|
||
| // Move non-prioritised atoms to the end of the list (to avoid burning our hands on lights when trying to open a closet) | ||
| for(var/atom/clickable as anything in atoms) | ||
| if(!clickable.interaction_priority) | ||
| atoms -= clickable | ||
| atoms += clickable |
Member
There was a problem hiding this comment.
wonder if it might be faster to create a custom comparator that's cmp_planelayer but anything with interaction_priority is sorted lower. that'd lower the number of times we need to loop over the contents list at least. not blocking but i'd at least like to consider it
|
|
||
| // Try to click something. | ||
| for(var/atom/clickable as anything in atoms) | ||
| if(!clickable.simulated) |
Member
There was a problem hiding this comment.
if we use facing.get_contained_external_atoms() instead of just facing.contents we can skip the simulated check and probably some other things we want to avoid here too
out-of-phaze
added
awaiting author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interaction_priorityto mark atoms that we are most interested in interacting with (so that lights above airlocks do not block interacting with the airlock).