Repository navigation
feat: default MiniMax text choices to M3.1 Flash - #414
Open
octo-patch wants to merge 2 commits into
Open
octo-patch wants to merge 2 commits into
octo-patch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Make MiniMax-M3.1-Flash the default ordinary text choice and avoid sending its unsupported disabled-thinking setting.
Summary
Type of change
Motivation (optional)
The existing M3 family regex also matches MiniMax-M3.1-Flash and sends
thinking: { type: "disabled" }, which Flash rejects. Flash requires adaptive thinking. The ordinary default and model picker also still recommend older MiniMax text models.Official contracts:
Changes
packages/core/src/llm/providers/endpoints/minimax.tspackages/core/src/llm/providers/model-choices.ts,providers/index.ts,service-presets.tspackages/core/src/llm/provider.ts,service-resolver.ts,utils/effective-llm-config.tspackages/core/src/index.ts,packages/studio/src/api/server.tsTest plan
minimax-config,minimax-model-choices,provider-minimax-thinking,providers-lookup, andproviders-schemapass with cached Vitest 3.2.4 and Zod 3.25.76 in an environment without provider or maintenance credentials; maximum two workers.pnpm typecheckpasses: unavailable locally. The focused strict compiler attempt stops at missing@mariozechner/pi-aideclarations.pnpm testpasses (all existing + new tests): full suite not run. Existing service-listing suites cannot load the missing lockedundicidependency.pnpm buildpasses: not run. Dependency installation and full builds are paused because this worker has less than 1 GiB free disk; no dependency downloads were attempted.Breaking changes (optional)
Ordinary recommendations no longer include obsolete MiniMax text models. Saved model IDs and their lookup metadata remain available; explicitly selected legacy models retain the historical default route. Custom/local catalogs, the legacy MiniMax Coding Plan, and nontext providers remain available under their existing contracts.