flake.nix: pnpmDeps, bump fetcherVersion = 4 - #1247
manuelbb-luh wants to merge 3 commits into
Conversation
nc-review: comments — 2 important, 1 nit@manuelbb-luh — a few things worth a look, none blocking. The PR bumps 🟠 important · The PR touches a user-facing surface (the nix flake build) — end users on recent nixpkgs currently cannot build 🟠 important · The header comment at the top of ⚪ nit · The new pnpmDeps hash ( 🔴 blocking · 🟠 a reviewer would ask for a change · ⚪ optional Automated code review — correctness, security, design, tests, plus duplicates and scope. A human still decides; this is not a substitute for review and is not exhaustive. The required status checks separately cover lint, formatting, types, unused dependencies, the test suite and the build. This bot never merges. Maintainers can rerun with |
|
Please can you address |
|
Hi @manuelbb-luh, thanks for this PR! It looks like a maintainer has left feedback Whenever you get a chance, could you take a look at the open comments? |
7d52cfa to
5643dca
Compare
|
Thanks for picking up the I verified the substance of the change locally and it's correct: nixpkgs master does now have One blocker though: The lock pins nixpkgs at Your local setup works because you override
Two stale comments left over as well:
Tiny nits: trailing whitespace on Once the lock bump is in I'll approve and get the checks approved to run. |
|
Hi @manuelbb-luh, thanks for this PR! It looks like a maintainer has left feedback Whenever you get a chance, could you take a look at the open comments? |
Description
Fix build failure with recent nixpkgs.
Support for
fetcherVersion = 3has been dropped: NixOS/nixpkgs#538919I have updated the version number and put in the hash I got on my local machine.
Have done no testing or anything, just noticed the issue when trying to upgrade my flake-based NixOS.
This is my current local workaround which builds successfully:
Type of Change
Changeset
pnpm changeset) describing this change for the changelogDocs-only or internal chores need no changeset (or run
pnpm changeset --emptyto note that intentionally).Testing
Automated Tests
.spec.ts/tsxfilespnpm test:allcompletes successfully)Manual Testing
Checklist