Repository navigation
fix: lay out docs text and install controls for phones - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier: low
site/.vitepress/theme(style.css,HeroInstall.vue,HomeWorkflows.vue). No content removed, no new dependency.Document height (px)
npm ciandnpx vitepress buildinsite/on main at f301969 (after the command reference gained the GitHub scan options) and on this branch merged with it, served under/codigest/. Chrome through Playwright,is_mobile, DPR 2.The two home pages do not get shorter: raising the installer tabs, the copy button and the code to the 14 px and 40 px minimums adds about as much as the tighter spacing removes.
Text nodes under 14 px at 360 px: 58 to 2 on the home page, 433 to 3 on the command reference (the remaining ones are the hidden skip link and a description label). Controls under 40 px by layout box: home 25 to 15, commands 70 to 53, configuration 27 to 11; the rest are the drawer rows and inline links.
Tried and left out
The option tables on
/commandsbreak flags such as--no-copyacross lines because the first column is about 80 px wide. Keeping each<code>on one line does not help:-c, --copy, --no-copyneeds about 190 px, which leaves the description column about 110 px, and long codes such as<user_instruction>then push the table wider than the screen. The PR instead lets long inline code wrap inside table cells. The workflow cards on the home page stay one per row because the commands do not fit 160 px.Screenshots (main on the left, this branch on the right):
docs/mobile/shots/codigest/in the NaNIsaac workspace. Images could not be uploaded to the PR from the CLI.Checks:
conventions.py check0 findings;npx vitepress buildsucceeds.