Noref/process inner hits properties bug#755
Open
danamansana wants to merge 2 commits into
Open
Conversation
charmingduchess
approved these changes
Jun 4, 2026
charmingduchess
left a comment
charmingduchess
left a comment
Contributor
There was a problem hiding this comment.
looks alright, tho i'm not totally clear on the cause. Was this erroring on bibs with no items? or on results with no bibs?
nonword
approved these changes
Jun 4, 2026
nonword
left a comment
nonword
left a comment
Member
There was a problem hiding this comment.
Seems like a logical move, but also seems like this means we weren't actually sorting previously, so let's look at item sort changes during QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an error message we've seen in the logs where
hit._source.items.sortis undefined, by adding a check ofhit._source.itemsAlso, previously the sort was applied before adding the
inner_hits, which seems wrong, so I've moved the sort to after addinginner_hits, but let me know if anyone knows a reason why it was done in the other order