Repository navigation
fix(trtllm): honor served model name in Dynamo sidecars - #622
Open
zhongdaor-nv wants to merge 1 commit into
Open
zhongdaor-nv wants to merge 1 commit into
zhongdaor-nv wants to merge 1 commit into
Conversation
Signed-off-by: Zhongdao Ren <zhongdaor@nvidia.com>
zhongdaor-nv
requested review from
alec-flowers,
csahithi,
hjjq,
ishandhanani,
kedarpotdar-nv,
kyleliang-nv,
nlevin-ui and
qiching
as code owners
October 24, 2026 23:04
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a cluster model alias resolves to local weights, TensorRT-LLM loads
/modelwhile clients requestengine.served_model_name(for example,Qwen/Qwen3-0.6B). The Dynamo sidecar previously registered/model, so requests using the configured served name failed with404 unknown_model.Use the existing served-name resolver for the sidecar's
--model-path, retaining the local-path and pinned-HF-ID fallbacks when no served name is configured. Add regression coverage for aggregate, prefill, and decode launches and document that this name must resolve to matching tokenizer/config artifacts; arbitrary display-only aliases are unsupported by this sidecar interface.Verified that the
ai-dynamo-runtime==1.6.0.dev20261016sidecar CLI has no separate served-name option. The upstream registration code inspected at27541b1usesmodel_pathas the registration name.Validation
make check: Ruff, formatting, type checking, and generated-doc checks passed; 5,181 tests passed, 3 skipped, 6 deselected, and 11 xfailed, including launch snapshot checks.make snapshotsand reviewed the generated launch plans; no snapshot changes are needed for the existing examples.uv run srtctl dry-run -f examples/trtllm/dynamo-sidecar-disagg.yamlpassed.