Repository navigation
fix(power): publish module power through a transient GPU disagreement - #619
Open
edwingao28 wants to merge 1 commit into
Open
edwingao28 wants to merge 1 commit into
edwingao28 wants to merge 1 commit into
Conversation
Publish a socket's mean through up to 3 consecutive disagreeing reads and withhold it from the 4th. In one GB200/GB300 CI sweep, 592 of 593 disagreements lasted 3 reads or fewer. Signed-off-by: Wenyao Gao <wenyao.gao28@gmail.com>
edwingao28
requested review from
alec-flowers,
csahithi,
ishandhanani and
nlevin-ui
as code owners
October 22, 2026 22:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NVML module reader omits a socket whose GPUs' readings differ by over 5%. Load steps split them briefly, enough for InferenceX's 3 s gap rule to drop
module_w. Publish the pair mean through 3 consecutive disagreeing reads; withhold from the 4th. Startup disables module power only when no GPU reports; a lone GPU cannot end a disagreement; only withholding warns.Testing: fmt, clippy, unit tests, strict mkdocs pass; new tests fail on the old rule. Startup, lone-GPU and logging changes are unit-tested only; hardware runs predate them. GB300 GEMM bursts vs v2.59.3: gaps over 3 s 7 → 0. Replaying sweep 39733456758: CI kept
module_won 12 of 22 benchmark points, the patched rule on all 22; 592/593 disagreements lasted ≤3 reads.Limits: A 1 s on/off load phase-locked to the poll blanks both builds (45-60 disagreeing reads). Disagreements of 5+ reads still leave ≥3 s gaps.