fix: record workflow gRPC call latency for monitoring#2702
Open
rsd-darshan wants to merge 2 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
Adds latency measurement and logging to gRPC calls in workflow activities. Introduces a shared helper function to standardize how gRPC call durations are logged across activities, enabling better observability of workflow performance. This addresses issue NVIDIA#2649 where workflow latency metrics were defined but not recorded. The duration is now captured and logged for each gRPC call, providing visibility into API response times for troubleshooting and performance monitoring. Fixes NVIDIA#2649 Signed-off-by: rsd-darshan <poudeldarshan44@gmail.com>
rsd-darshan
force-pushed
the
fix/record-workflow-latency-metrics
branch
from
b4fbd86 to
0ae41ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2649
Summary
Adds latency measurement and logging to gRPC calls in workflow activities. Workflow latency metrics were previously defined in site-agent's coregrpc manager but never actually recorded. This change instruments the activities to measure and log the duration of each gRPC call to NICo.
Changes
latency.gowith a shared helperlogGrpcCallLatency()to standardize duration logging across activitiesvpcprefix.goactivities (Create, Update, Delete) to measure gRPC call durationinstance.goUpdateInstanceConfig activity with latency measurementBenefits
Testing
All existing tests pass. Verified that duration logging appears in test output with actual measured latencies.