Precompiled: Ubuntu26.04 x86 driver container support#758
Conversation
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
3 times, most recently
from
2b85890 to
021be8a
Compare
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
4 times, most recently
from
97a8b97 to
a08b959
Compare
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
from
13a221e to
38a1329
Compare
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
3 times, most recently
from
ba62a87 to
a4586ff
Compare
shivakunv
requested review from
cdesiniotis,
rahulait,
rajathagasthya and
tariq1890
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
2 times, most recently
from
49246e8 to
d9382bf
Compare
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
2 times, most recently
from
dfeff99 to
9643b7a
Compare
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
from
9643b7a to
38f2dda
Compare
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
from
68a4b71 to
3c95329
Compare
rajathagasthya
changed the title
| @@ -0,0 +1,1489 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Why do we have this script here instead of downloading it like Ubuntu 24.04?
There was a problem hiding this comment.
Let's not paste the nvidia-installer script here. We always want to download a specific nvidia-installer script/binary based on the driver version we are containerising
There was a problem hiding this comment.
After removing the local nvidia-installer script, we have two options:
1: Match ubuntu22.04/24.04 — extract from the .run
Use the existing fetch_nvidia_installer pattern: download NVIDIA-Linux-${ARCH}-${DRIVER_VERSION}.run from https://us.download.nvidia.com/tesla/, run sh -x to extract, copy out nvidia-installer, and clean up the rest. Same flow as ubuntu22.04 and ubuntu24.04 already use.
2: Build from source
Download the source https://github.com/NVIDIA/nvidia-installer, build it with make, and install the resulting binary.
please suggest @tariq1890
There was a problem hiding this comment.
Let's follow what's being done for ubuntu22.04/24.04. I don't see a reason to build from source.
There was a problem hiding this comment.
we are already following the same approach as Ubuntu 22.04/24.04 by extracting nvidia-installer from the .run file .
2nd point suggested for removal of .run file
| @@ -0,0 +1,1489 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Let's not paste the nvidia-installer script here. We always want to download a specific nvidia-installer script/binary based on the driver version we are containerising
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
from
3c95329 to
d697a7c
Compare
shivakunv
dismissed
tariq1890’s stale review
latest commit includes the code changes
|
|
||
| # Install / upgrade packages here that are required to resolve CVEs | ||
| ARG CVE_UPDATES | ||
| RUN if [ -n "${CVE_UPDATES}" ]; then \ |
There was a problem hiding this comment.
no-op
need basis :-
We can add this later in CI ( .gitlab-ci.yaml or as ci/cd variable) , no changes to Dockerfile are needed.
| @@ -0,0 +1,1489 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
After removing the local nvidia-installer script, we have two options:
1: Match ubuntu22.04/24.04 — extract from the .run
Use the existing fetch_nvidia_installer pattern: download NVIDIA-Linux-${ARCH}-${DRIVER_VERSION}.run from https://us.download.nvidia.com/tesla/, run sh -x to extract, copy out nvidia-installer, and clean up the rest. Same flow as ubuntu22.04 and ubuntu24.04 already use.
2: Build from source
Download the source https://github.com/NVIDIA/nvidia-installer, build it with make, and install the resulting binary.
please suggest @tariq1890
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
shivakunv
force-pushed
the
precompiled-ubuntu26.04
branch
from
d697a7c to
7d4d099
Compare
4 participants
No description provided.