[FEA] Multi-node Out of Core Streaming KMeans API#2066
Open
tarang-jain wants to merge 195 commits into
Open
Conversation
…nto combine-batch
…nto combine-batch
…nto combine-batch
Contributor
Author
|
/ok to test d0fa3a9 |
viclafargue
approved these changes
Jun 12, 2026
viclafargue
left a comment
Contributor
There was a problem hiding this comment.
Great work! Pre-approving, just have two points that may need some attention.
…into mnmg-streaming
viclafargue
reviewed
Jun 12, 2026
Contributor
Author
|
/ok to test 3321926 |
viclafargue
approved these changes
Jun 15, 2026
lowener
reviewed
Jun 15, 2026
Contributor
Author
|
/ok to test bd3e1de |
Contributor
Author
|
/merge |
Contributor
Author
|
/ok to test 40c77ca |
Contributor
Author
|
/ok to test 079c216 |
Contributor
Author
|
/ok to test 7a38f62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #2015 and #2017
Allows a stream of input matrices per worker, that are further batched using the
streaming_batch_sizeparameter. Reasoning: We should be able to supply dask partitions (on host) directly without having to concatenate them into one consolidated matrix.As a part of this PR, we also unify the multi-GPU implementations into one (earlier the out of core implementation was separate).
Tests: We get rid of the separate out of core test file. The single MG testing unit is taking care of both out of core and on device matrices.