Add custom section support to SFT TOML configuration#57
Open
main-voice wants to merge 10 commits into
Open
Conversation
Signed-off-by: Alex Peng <haopeng@nvidia.com>
foreverlms
reviewed
Jun 25, 2026
lfengad
reviewed
Jun 25, 2026
| dataloader_train: object = None | ||
|
|
||
|
|
||
| class TestCustomInterpolationAndAccess: |
Collaborator
There was a problem hiding this comment.
The test here could put into cosmos_framework/ and make this test in the same format with the other *test.py in cosmos_framework/ such as inference/prompt_upsampling_test.py? to make sure the unittest job in the current ci tests could automatically grep and run it?
Author
There was a problem hiding this comment.
Good call, thanks to clarify the tests structure
Updated the `load_experiment_from_toml` function to utilize `load_config` with a `pre_override` hook for injecting the `[custom]` section into the config before applying overrides. This ensures that custom configurations are part of the OmegaConf tree resolved by Hydra. Additionally, modified the `load_config` and `_load_py_config` functions to accept the `pre_override` parameter for enhanced configurability. Documentation for SFT configuration has been updated to reflect these changes.
Signed-off-by: Alex Peng <haopeng@nvidia.com>
yy-code-nv
reviewed
Jun 25, 2026
…oice/cosmos-framework into feat/support-custom-config-fields
yy-code-nv
previously approved these changes
Jun 26, 2026
foreverlms
reviewed
Jun 26, 2026
…oice/cosmos-framework into feat/support-custom-config-fields
foreverlms
previously approved these changes
Jun 26, 2026
lfengad
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.