Skip to content

[24.04_linux-nvidia-7.0-next] NVIDIA: SAUCE: watchdog: sbsa_gwdt: add force_enable module parameter - #521

Open
abhsahu wants to merge 1 commit into
NVIDIA:24.04_linux-nvidia-7.0-nextfrom
abhsahu:sbsa_gwdt_force_enable_parameter_patch
Open

[24.04_linux-nvidia-7.0-next] NVIDIA: SAUCE: watchdog: sbsa_gwdt: add force_enable module parameter#521
abhsahu wants to merge 1 commit into
NVIDIA:24.04_linux-nvidia-7.0-nextfrom
abhsahu:sbsa_gwdt_force_enable_parameter_patch

Conversation

@abhsahu

@abhsahu abhsahu commented Aug 3, 2026

Copy link
Copy Markdown

This PR contains path to backport change from mailing list https://lkml.org/lkml/2026/8/3/510
It is tracked with Internal Bug 6417508

@nirmoy nirmoy added the help wanted Extra attention is needed label Aug 3, 2026
@nirmoy

nirmoy commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

BaseOS Kernel Review

Summary

No issues found across the reviewed commits.

Findings: no problems found

Latest watcher review: open review

Generated test plan: open test plan

Kernel deb build: successful (download debs, 4 files)

Head: c37a58f20cef

This comment is maintained by nv-pr-bot. It is updated when the GitHub watcher publishes a newer review.

@nirmoy

nirmoy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@abhsahu the link in the patch is broken: https://lore.kernel.org/lkml/2026/8/3/510

@abhsahu
abhsahu force-pushed the sbsa_gwdt_force_enable_parameter_patch branch from 168de4a to fb0744a Compare August 3, 2026 14:05
Zexin Wang @abhsahu
NVIDIA: SAUCE: watchdog: sbsa_gwdt: add force_enable module parameter
c37a58f 
The sbsa_gwdt driver only manages and registers the watchdog timer if it
was already enabled by a previous boot stage (such as firmware). If the
watchdog was left disabled prior to entering the kernel, the driver
will not actively enable it during the probe phase.

Introduce a new module parameter 'force_enable' to allow overriding this
behavior. When 'force_enable' is set, the driver will forcibly start
the watchdog and register it as running during the probe phase, even if
it was disabled in the previous boot stage.

Signed-off-by: Zexin Wang <ot_zexin.wang@mediatek.com>
(backported from https://lore.kernel.org/all/20260803071823.27759-1-ot_zexin.wang@mediatek.com/)
Signed-off-by: Abhishek Sahu <abhsahu@nvidia.com>
@abhsahu
abhsahu force-pushed the sbsa_gwdt_force_enable_parameter_patch branch from fb0744a to c37a58f Compare August 3, 2026 14:09
@abhsahu

abhsahu commented Aug 3, 2026

Copy link
Copy Markdown
Author

@abhsahu the link in the patch is broken: https://lore.kernel.org/lkml/2026/8/3/510

Thanks @nirmoy I have fixed the link.

@jamieNguyenNVIDIA

jamieNguyenNVIDIA commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @abhsahu,

You should target this PR at the following branches instead of 24.04_linux-nvidia-7.0-next:

  • 26.04_linux-nvidia-bos
  • 26.04_linux-nvidia

Canonical helps ensure that the 24.04 kernel source is kept in sync with the 26.04 versions, so no need to target PRs at the 24.04+7.0 branches.

@nvmochs

nvmochs commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@abhsahu There was some feedback on LKML today about the parameter name. I think it would be best to settle on that before getting this integrated into NV-Kernels to avoid API differences.

Additionally, here are 2 findings from review with Codex:

  • P2 drivers/watchdog/sbsa_gwdt.c:396: force_enable=1 can immediately start MediaTek hardware without the existing WS0 race workaround if action=1 falls back to single-stage mode because IRQ lookup/request fails. The workaround is computed before the fallback at drivers/watchdog/sbsa_gwdt.c:249, but action can be changed later at drivers/watchdog/sbsa_gwdt.c:363. Recompute/apply need_ws0_race_workaround after the final action value is known, before watchdog_init_timeout(), sbsa_gwdt_set_timeout(), and the new forced start path.

  • P3 drivers/watchdog/sbsa_gwdt.c:126: the new force_enable module parameter is not added to the documented sbsa_gwdt parameter list at Documentation/watchdog/watchdog-parameters.rst:510. That file says watchdog driver parameters should be listed there unless the driver has separate docs.

@abhsahu

abhsahu commented Aug 4, 2026

Copy link
Copy Markdown
Author

Thanks @jamieNguyenNVIDIA and @nvmochs
We can then wait for this patch to get reviewed in LKML first.
Regaring codex review finding, I will update that in our internal bug.

@nirmoy

nirmoy commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@abhsahu should this be closed then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

help wanted Extra attention is needed pending_review_comment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhsahu @nirmoy @jamieNguyenNVIDIA @nvmochs