Skip to content

fix(sharpa-avatar): address three glove integration tickets - #1263

Open
zihanjiang321 wants to merge 1 commit into
NVIDIA:mainfrom
zihanjiang321:fix/sharpa-avatar-exo-main
Open

zihanjiang321 wants to merge 1 commit into
NVIDIA:mainfrom
zihanjiang321:fix/sharpa-avatar-exo-main

Conversation

@zihanjiang321

@zihanjiang321 zihanjiang321 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Fixes the three ticket items.

Summary by CodeRabbit

  • Documentation
    • Clarified that AvatarExo gloves use a wireless connection through the USB dongle, and documented the available dataset options and defaults.
    • Clarified that the plugin does not support a --transport option and should not run alongside Avatar Desktop or avatar-backend.
  • Bug Fixes
    • Improved glove tracking and haptic handling by waiting for fresh data and responding to reported disconnections.
    • Updated little-finger visualization to match the landmarks available in Avatar HUMAN data.

@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview is not auto-deployed for fork PRs.

A maintainer with write access to NVIDIA/IsaacCapture can deploy a preview by
commenting /preview-docs on this PR. Once deployed, the preview
will live at:

https://nvidia.github.io/IsaacCapture/preview/pr-1263/

Signed-off-by: zihan <zihan.jiang@sharpa.com>
(cherry picked from commit dbac00bb0fce096a1192faf4adb25a503afe653e)
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/IsaacCapture/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 6482ef7b-3e04-4a09-8093-0e2eecc9d323
📥 Commits

Reviewing files that changed from the base of the PR and between 1641ca8 and 39a1498.

📒 Files selected for processing: 7
  • docs/source/device/sharpa_avatar.rst
  • examples/sharpa_avatar/README.md
  • examples/sharpa_avatar/python/isaaccapture_examples/sharpa_avatar/live_view.py
  • src/plugins/sharpa_avatar/AGENTS.md
  • src/plugins/sharpa_avatar/README.md
  • src/plugins/sharpa_avatar/core/avatar_hand_tracking_plugin.cpp
  • src/plugins/sharpa_avatar/core/inc/avatar/avatar_hand_tracking_plugin.hpp

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Walkthrough

The tracker now checks SDK device status, waits for a fresh sample before creating per-glove output resources, and removes those resources when a device reports offline. Joint output uses fixed RAW and ROBOT name tables. Data refresh and haptic commands require a ready glove. Documentation describes wireless USB-dongle operation, and the live view skips unavailable little-finger landmarks.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant AvatarTracker
  participant SDK
  participant Glove
  participant DeviceIO
  AvatarTracker->>SDK: checks device information
  AvatarTracker->>Glove: starts online device
  Glove->>AvatarTracker: reports fresh raw-human frame
  AvatarTracker->>DeviceIO: creates per-side output resources
Loading
Merge Risk: ⚪ Minimal · up to 39a14

The change updates glove readiness handling, documentation, and the live view. No concrete merge-blocking defect has been established.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 3 files. (4 skipped: 4… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the change as fixes for three Sharpa Avatar glove integration issues. It is concise and related to the main changes, although it does not identify the individual issues…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 3 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants