Repository navigation
test(metric-benchmark): revalidate sealed jobs after validation failure - #163
Open
mstaats-nvidia wants to merge 1 commit into
Open
mstaats-nvidia wants to merge 1 commit into
mstaats-nvidia wants to merge 1 commit into
Conversation
Signed-off-by: mstaats <mstaats@nvidia.com>
asutermo
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A job receipt is written before case validation. Add a regression test proving that a validation failure does not let sealed jobs bypass validation on resume.
The fake Harbor runner emits a trial with an incorrect task checksum before sealing. The test checks that both attempts fail real validation, all three job receipts exist, resume never invokes Harbor, no results index or experiment manifest is published, and saved files remain byte-identical. Production code is unchanged.
Follow-up to the receipt-ordering review concern on #106.
Validation:
12c9718with itsload_execution(cases.yml, execution.yml)fixture-loading adjustment; that branch was not modified.