Repository navigation
Conversation
https://mn.cs.tsinghua.edu.cn/avqa now answers 403 and redirects to a webvpn gateway, so the docs linkcheck fails on main: { "filename": "guides/grpo-audio.md", "lineno": 18, "status": "broken", "uri": "https://mn.cs.tsinghua.edu.cn/avqa", "info": "403 Client Error: Forbidden for url: https://webvpn.tsinghua.edu.cn/..." } The 3B recipe does not load anything from that host. It pulls the pre-processed split from gijs/avqa-processed on the Hub, which the same section already names two sentences later. Point the recipe table there, matching how the 7B and 30B rows link their datasets. The prose mention keeps the dataset's full name but drops its link, since the sentence it sits in already links the processed dataset and the R1-AQA paper; a third link to the same place would add nothing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: ruit <ruit@nvidia.com>
Contributor
Author
|
/ok to test ab818c8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Why this is needed:
https://mn.cs.tsinghua.edu.cn/avqaintermittently answers 403 to the CI runner, which makes the docs jobrelease / finalize / build-docs / Build docsfail at random. It has been red onmainand several open PRs since 2026-10-29. This PR points the reference at the dataset the recipe actually loads, removing the unstable host from the docs build.What breaks, and how often
The repo's linkcheck gate fails on any broken link not in an exclusion list:
Nothing in the repo changed — the link has been in the guide since #2356 (2026-06-09), and
mainwas green on this job through6f6772f74(2026-10-29 09:33 UTC). It went red ate9bfd9f78(13:47 UTC) and has stayed red on the runs since. Re-running the job makes it pass, which is what identifies this as rate-limiting rather than a dead page.Who it hits
Anyone with an open PR, not just this guide's authors — the docs build runs on every branch and checks every link regardless of what a PR touches. Confirmed failing at this same step:
main—dd2e251da,0b305c998,e9bfd9f78Each one costs somebody a manual re-run, and a flaky gate trains people to ignore it.
Why replace the link rather than add an exclusion entry
Adding the URL to
docs/broken_links_false_positives.jsonis a legitimate option, and the repo already does exactly that forgithub.comwith the note "Github links are now getting rate limited from the Github Actions". This is the same class of problem.I went with the replacement because it fixes an inaccuracy at the same time. The 3B recipe never loaded anything from that host — it pulls the pre-processed split from
gijs/avqa-processedon the Hub, which the same section already names two sentences below the table. Pointing the "Default dataset" column there makes it name what the recipe actually loads, matching the 7B and 30B rows.If reviewers would rather keep the project-page link, the exclusion entry is the alternative and I am happy to switch.
The prose mention under
### AVQAkeeps the dataset's full name but drops its link: that sentence already links the processed dataset and the R1-AQA paper, so a third link to the same place adds nothing. The project page is still worth citing somewhere if someone wants it back — it is live, just unfriendly to automated checkers.Issues
No issue filed — surfaced by the red
Build docsjob.Result
grep -rn "mn.cs.tsinghua.edu.cn" docs/ examples/ nemo_rl/ tests/returns nothing after this change. The replacement URL loads:gijs/avqa-processed, ~56k rows, nativetrainandvalidationsplits — which is what the paragraph says AVQA has, so the surrounding text stays true.Before your PR is "Ready for review"
Pre checks:
Additional Information
This does not fix
mainon its own — the red runs there need a re-run or a new push to pick the change up.🤖 Generated with Claude Code