Repository navigation
Update tmp dir - #107
Merged
Merged
Update tmp dir#107
Conversation
Set the default new_path for Eiger file operations to '/tmp/'.
Temporarily removed a test for investigation purposes.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The serialization fix is focused, dependency-complete, and covered by the existing round-trip test.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes XPCS HDF5 serialization by separating h5py and pandas writes and declaring the required PyTables dependency.
Changes:
- Writes DataFrames only after closing the h5py handle.
- Adds
tables>=3.9. - Documents
/tmp/defaults.
| File | Description |
|---|---|
pyproject.toml |
Adds PyTables dependency. |
pyCHX/Create_Report.py |
Prevents concurrent HDF5 access. |
pyCHX/chx_generic_functions.py |
Clarifies temporary-directory defaults. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed broken test