Skip to content

Add Lambda and Pilatus area detectors to the profile - #5

Merged
Anthony Sligar (sligara7) merged 1 commit into
NSLS2:pdf-profile-conversionfrom
sligara7:pdf-conv-03a-lambda-pilatus
Oct 23, 2026
Merged

Anthony Sligar (sligara7) merged 1 commit into
NSLS2:pdf-profile-conversionfrom
sligara7:pdf-conv-03a-lambda-pilatus

Conversation

@sligara7

Copy link
Copy Markdown

Adds lambda1 (XSPDetector) and pilatus1 (PilatusDetector) to the profile, both writing TIFF via NSLS2PathProvider, ported from pdf-profile-collection (81-pilatus, 84-lambda).

  • Pilatus is assumed to be a PILATUS3 (default readout_time); the model is not yet confirmed. Pilatus-specific helpers (threshold energy, power reset) are not ported.

Verified: mock tests only — a mock Pilatus count with the TIFF writer (tests/test_detectors.py/test_pilatus.py) and the profile booting in mock mode with both detectors initialised. Not yet run on the TST or real beamline.

Both write TIFF through NSLS2PathProvider, as in pdf-profile-collection (81-pilatus, 84-lambda). Pilatus is assumed to be a PILATUS3 (default readout_time) until the model is confirmed.

Assisted-by: copilot:claude-opus-5-5
Copilot AI balanced review requested due to automatic review settings October 23, 2026 20:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Pilatus model remains unconfirmed, and mock-only verification leaves hardware timing, connectivity, and TIFF writing requiring human validation.

No open issues 🎉

What changed in this PR

Adds Lambda and Pilatus area detectors to the collection profile, using TIFF writers configured with the shared NSLS2PathProvider.

Changes:

  • Initializes lambda1 as an XSPDetector and pilatus1 as a PilatusDetector.
  • Adds a mock Pilatus count test covering TIFF resource metadata and frame indices.
  • Extends the mock profile startup test to check that both detectors initialize successfully.
File Description
tests/​test_utils.py Checks successful initialization of both detectors in mock mode.
tests/​test_detectors.py/​test_pilatus.py Tests mock Pilatus acquisition and TIFF document metadata.
src/​pdftools/​profiles/​collection.py Registers both detectors with TIFF writers and the shared path provider.

Review effort: Balanced

@sligara7
Anthony Sligar (sligara7) merged commit f5d4ba8 into NSLS2:pdf-profile-conversion Oct 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants