Repository navigation
Add Lambda and Pilatus area detectors to the profile - #5
Merged
Anthony Sligar (sligara7) merged 1 commit intoOct 23, 2026
Conversation
Both write TIFF through NSLS2PathProvider, as in pdf-profile-collection (81-pilatus, 84-lambda). Pilatus is assumed to be a PILATUS3 (default readout_time) until the model is confirmed. Assisted-by: copilot:claude-opus-5-5
There was a problem hiding this comment.
🔵 Needs a closer look
The Pilatus model remains unconfirmed, and mock-only verification leaves hardware timing, connectivity, and TIFF writing requiring human validation.
No open issues 🎉
What changed in this PR
Adds Lambda and Pilatus area detectors to the collection profile, using TIFF writers configured with the shared NSLS2PathProvider.
Changes:
- Initializes
lambda1as anXSPDetectorandpilatus1as aPilatusDetector. - Adds a mock Pilatus count test covering TIFF resource metadata and frame indices.
- Extends the mock profile startup test to check that both detectors initialize successfully.
| File | Description |
|---|---|
tests/test_utils.py |
Checks successful initialization of both detectors in mock mode. |
tests/test_detectors.py/test_pilatus.py |
Tests mock Pilatus acquisition and TIFF document metadata. |
src/pdftools/profiles/collection.py |
Registers both detectors with TIFF writers and the shared path provider. |
Review effort: Balanced
Anthony Sligar (sligara7)
merged commit Oct 23, 2026
f5d4ba8
into
NSLS2:pdf-profile-conversion
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
lambda1(XSPDetector) andpilatus1(PilatusDetector) to the profile, both writing TIFF viaNSLS2PathProvider, ported from pdf-profile-collection (81-pilatus, 84-lambda).readout_time); the model is not yet confirmed. Pilatus-specific helpers (threshold energy, power reset) are not ported.Verified: mock tests only — a mock Pilatus count with the TIFF writer (
tests/test_detectors.py/test_pilatus.py) and the profile booting in mock mode with both detectors initialised. Not yet run on the TST or real beamline.