[Anthony Sligar (sligara7)]

First step of converting pdf-profile-collection into pdftools, into the long-lived pdf-profile-conversion branch (main is untouched).

• Applies nsls2-tools-template (copier, 2621848): pixi instead of uv, template pyproject/pre-commit/CI/publish/lockfile refresh, and the mockable profile src/pdftools/profiles/collection.py. .copier-answers.yml is included so pixi run -e dev update-template works later.
• Existing modules only gain the docstrings the template's ruff rules require; no code changes.
• test_xspd expects (1, 5, 3, 4): bluesky-tiled-plugins 2.0.11 made join_method="stack" the default (the old uv lock had 2.0.2).

Verified: mock tests only. pixi run -e dev lint (all hooks pass), pixi run -e dev tests (5 passed), the profile boots with --mock, hatch build succeeds. No beamline use.

[Copilot]

🟡 Changes recommended

Dependency declarations permit older releases incompatible with the retained detector APIs and updated data-shape assertion.

2 open issues

• Restore ophyd-async minimum version in package metadata · New
• Align bluesky-tiled-plugins minimum with shape assertion · New

What changed in this PR

This first conversion step adopts nsls2-tools-template for pdftools on the long-lived conversion branch, leaving main untouched.

Changes:

• Replaces uv tooling with Pixi and Hatch, updating linting, CI, publishing, and dependency maintenance.
• Adds a mockable collection profile and package-version tests.
• Adds device docstrings and updates the detector test for event-stacked data.

File	Description
tests/​test_version.py	Tests package imports and installed version consistency.
tests/​test_detectors.py/​test_xspd.py	Expects event-stacked detector data.
src/​pdftools/​sample_environment.py	Adds and standardizes device docstrings.
src/​pdftools/​py.typed	Marks the package as typed.
src/​pdftools/​profiles/​collection.py	Adds a mockable acquisition profile.
src/​pdftools/​motors.py	Adds motion-device docstrings.
src/​pdftools/​detectors/​xspd.py	Adds and standardizes detector docstrings.
src/​pdftools/​detectors/​__init__.py	Adds a module docstring.
src/​pdftools/​__init__.py	Exposes the generated package version.
README.md	Clarifies the beamline’s facility.
pyproject.toml	Adopts Hatch and template dependency/tool settings.
pixi.toml	Defines environments and development tasks.
.python-version	Removes the standalone Python version pin.
.pre-commit-config.yaml	Updates linting, typing, and formatting hooks.
.gitignore	Expands generated-file and environment exclusions.
.github/​workflows/​refresh-lockfile.yml	Adds automated Pixi lockfile refreshes.
.github/​workflows/​publish-pypi.yml	Uses Pixi and Hatch for release builds.
.github/​workflows/​ci.yml	Adds Pixi-based lint, test, and build jobs.
.github/​workflows/​ci.yaml	Removes the previous uv-based workflow.
.github/​dependabot.yml	Groups monthly GitHub Actions updates.
.copier-answers.yml	Records template inputs for future updates.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Automated lockfile PRs use the default token, preventing the configured CI checks from running on those updates.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Use a token that triggers CI for generated PRs

.github/​workflows/​refresh-lockfile.yml:37

Without a token input, create-pull-request uses GITHUB_TOKEN. As documented by the action, PR creation and branch updates made with this token do not trigger pull_request or push workflows. Generated lockfile PRs therefore receive no automatic lint, test, or build checks from ci.yml, which also lacks a manual dispatch trigger. Supply a GitHub App token or personal access token with the required permissions, or explicitly run CI against each generated PR head before merging.

2 resolved since last review

• Restore ophyd-async minimum version in package metadata
• Align bluesky-tiled-plugins minimum with shape assertion

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

Remaining feedback is non-blocking, and no approval-blocking defects were identified within this template-adoption scope.

1 open issue

• Update CI badge URLs from ci.yaml to ci.yml · New

_{Review effort: Balanced}