[Anthony Sligar (sligara7)]

Adds pdftools.lakeshore336 and lake / cryostat = lake.out1 to the profile. It is a port of Cheng-Hung's ophyd-async device in pdf-profile-collection startup/101-Lakeshore336Cryostat.py (129831d), keeping its names, PID tables, 5–550 K limits and the loop/input wiring (out1 reads input C, tolerance 1 K, settle 120 s).

Checked against the live lakeshore336 IOC on xf28id1-inst-ioc1 (XF:28ID1-ES{LS336:1}, its records.dbl and db/ files, 2026-10-26): every suffix the device uses is served, and the enum classes equal the records' states. Changes from the profile file:

• loop_in_rb (Out-Sts, an mbbi) is read-only.
• Lakeshore336RangeSelect gains RANGE 4/5, as the record has them.
• check_move says why it refuses.

Fixed after Copilot's review (77d77e1): the zero-ramp fallback is in K/min; PIDs are set in move(), so a move with its own timeout sets them too; the deadline covers the PID and setpoint writes; the loop's measured temperature is a hinted reading, so scans record it. Still as in the profile: move_timeout is unused; default_loop, move_and_continue and t_list are left for the Lakeshore temperature series PR.

Verified: mock tests (PV names pinned to the IOC's record list, enum states, PID choice per direction, settle, limits, timeout); 100 pass. Not run on the beamline.

[Copilot]

🟡 Changes recommended

PID setup, timeout calculation and enforcement, and measured-temperature recording have unresolved correctness issues.

4 open issues

• Convert zero-ramp fallback from K/s to K/min · New
• Apply direction-dependent PIDs independently of timeout · New
• Bound setpoint writes by the move timeout · New
• Register movable temperature readback as a readable signal · New

What changed in this PR

Adds an ophyd-async Lake Shore 336 cryostat device and integrates it into the collection profile, preserving the previous profile’s PID tables, temperature limits, and loop/input mappings.

Changes:

• Implements temperature inputs, control loops, direction-dependent PID selection, and settling logic.
• Exposes lake and the cryostat = lake.out1 alias.
• Adds mock tests for IOC mappings, enums, movement, limits, and timeouts.

File	Description
tests/​test_lakeshore336.py	Adds mocked device and movement tests.
src/​pdftools/​profiles/​collection.py	Instantiates the controller and exposes the cryostat alias.
src/​pdftools/​lakeshore336.py	Implements the controller’s signals and temperature-move logic.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The physical heater-control integration needs final beamline review because behavioral validation is mock-only.

No open issues 🎉

4 resolved since last review

• Register movable temperature readback as a readable signal
• Bound setpoint writes by the move timeout
• Apply direction-dependent PIDs independently of timeout
• Convert zero-ramp fallback from K/s to K/min

_{Review effort: Balanced}