Update DL_visuals for pelicun 3.10 - #432
Merged
Merged
Conversation
PBE needs the on-disk location of each default model dataset so it can offer them in the component database selector. pelicun 3.10 moved these datasets out of the package tree and into the separately installed DLML package, where their paths are only discoverable through the library's resolver. Add a `query dataset_paths` keyword that reads the method alias map from the pelicun resources folder, resolves each alias through `pelicun.file_io.resolve_default_dataset_path`, and writes a single JSON object mapping each alias to its absolute dataset directory and its DLML dataset ID. Leave the `query default_db` output untouched; older PBE builds parse it.
Modern plotly emits the CDN script tag with integrity and crossorigin attributes that fail Chromium's CORS check in the PBE figure viewer, and its bundle injects :focus-visible CSS rules that the Chromium in Qt 5.15 cannot parse. This leaves the figure area blank. Write the plotly.js bundle into each figure folder and reference it relatively (include_plotlyjs='directory'), with the :focus-visible selectors downgraded to :focus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits that keep the PBE figure pipeline working with pelicun 3.10:
query dataset_pathskeyword maps each default-DB alias toits resolved dataset directory and dataset ID through pelicun 3.10's
resolver (the model library now lives in the separately installed DLML
package).
query default_dbis unchanged, and a pelicun older than 3.10gets a clear error instead of a traceback.
to them instead of the CDN. The CDN tag's SRI/CORS attributes and the
bundle's
:focus-visibleCSS rules both break the figures in PBE'sQtWebEngine viewer; the bundle is patched accordingly and refreshed into
cached figure folders automatically.