Repository navigation
Add persisted pause countdown to EVR views (#506) - #507
Open
mudinthewater wants to merge 2 commits into
Open
mudinthewater wants to merge 2 commits into
mudinthewater wants to merge 2 commits into
Conversation
Persist configuration.pauseTimerSeconds for vista.evrView and show an orange pause-countdown status action while the table is paused. At zero the view resumes as if Play were pressed; selecting the countdown stays paused, and marking more rows restarts it. Absent or invalid values keep the previous pause-until-Play behaviour. The setting lives in the Config tab between Layout and Columns via an EVR fork of core TableConfiguration. The view observes the parent configuration object (writers mutate that path; child-path observers never fire) so edits apply to the open view immediately.
Use Number.NaN in the countdown spec, move orderCountdownAfterPlay to module scope, chain the countdown invoke through an optional view, and drop the unneeded !important from the countdown button background (its selector already outranks the core button background).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist configuration.pauseTimerSeconds for vista.evrView and show an orange pause-countdown status action while the table is paused. At zero the view resumes as if Play were pressed; selecting the countdown stays paused, and marking more rows restarts it. Absent or invalid values keep the previous pause-until-Play behaviour.
The setting lives in the Config tab between Layout and Columns via an EVR fork of core TableConfiguration. The view observes the parent configuration object (writers mutate that path; child-path observers never fire) so edits apply to the open view immediately.