Repository navigation
Run Karma coverage before SonarCloud scan (#504) - #505
Open
mudinthewater wants to merge 6 commits into
Open
mudinthewater wants to merge 6 commits into
mudinthewater wants to merge 6 commits into
Conversation
The SonarCloud workflow never ran the test suite, so no coverage report existed when the scanner ran and coverage read 0%. Add Node setup, npm ci, and a Karma run (ChromeHeadlessNoSandbox for CI runners) ahead of the scan, emit lcov from Karma, and point sonar.javascript.lcov.reportPaths at it.
package-lock.json is gitignored in this repo, so setup-node's npm cache fails with 'Dependencies lock file is not found' and npm ci would fail the same way. Use a plain npm install.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # No lock file is committed (package-lock.json is gitignored), so | ||
| # neither setup-node's npm cache nor npm ci can be used here. | ||
| - name: Install dependencies | ||
| run: npm install |
| # No lock file is committed (package-lock.json is gitignored), so | ||
| # neither setup-node's npm cache nor npm ci can be used here. | ||
| - name: Install dependencies | ||
| run: npm install |
added 2 commits
October 20, 2026 23:05
Several imports referenced directories/files with different letter casing than what exists on disk (frameSummary vs framesummary, frameAccountability vs frameaccountability, encodingWatch vs encodingwatch). This resolves fine on case-insensitive filesystems (e.g. macOS) but fails webpack module resolution on case-sensitive ones (most Linux distributions), fully blocking the production build.
The default export bound to VistaStyles never existed (MiniCssExtractPlugin produces no exports for the CSS module) and was never used. Under the project's ESM output config (experiments.outputModule) webpack treats a missing default export as a hard build error rather than resolving to undefined, so this dead import broke the production build entirely.
Collaborator
Author
|
Note this one is failing cause we need to pull in these two PRs first: The only errors I see are because we didn't pull in these two PRS: (See I didn't make it up the vista style import does block builds @jvigliotta) I cherry-picked em into here to verify it works. |
|
mudinthewater
added
the
Falls-Prio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #504
The SonarCloud workflow never ran the test suite, so no coverage report existed when the scanner ran and coverage read 0%. Add Node setup, npm ci, and a Karma run (ChromeHeadlessNoSandbox for CI runners) ahead of the scan, emit lcov from Karma, and point sonar.javascript.lcov.reportPaths at it.
This way when we do new PRs instead of every sonarqube failing (even if it has coverage) it should produce a result.