Skip to content

Feat lazy user folder creation - #503

Open
mudinthewater wants to merge 3 commits into
release/6.0.2from
feat-lazy-user-folder-creation
Open

mudinthewater wants to merge 3 commits into
release/6.0.2from
feat-lazy-user-folder-creation

Conversation

@mudinthewater

@mudinthewater mudinthewater commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Okay when doing #54 I decided it would be much easier to just not create the namespace or root until a user actually puts an object in it. No namespace or root, no folder.

@mudinthewater
mudinthewater changed the base branch from main to release/6.0.2 October 20, 2026 06:45
The current user's folder is now represented in the tree without
persisting anything: getContainedNamespaces no longer creates the
namespace, MCWSPersistenceProvider.get returns a synthetic folder
model (deliberately unpersisted) for the current user's own root,
and the namespace plus root file are only created when an object
is first created inside the folder. The legacy interceptor no
longer recreates user folders on read. Users who only view leave
no folder behind, reducing tree clutter on large projects.
@mudinthewater
mudinthewater force-pushed the feat-lazy-user-folder-creation branch from 8940fa9 to 23571f5 Compare October 20, 2026 06:51
Cover the non-root miss and namespace-read failure branches of the
new folder helpers, and emit an lcov report from Karma
(target/coverage/lcov.info) wired into sonar-project.properties
so Sonar can ingest coverage instead of reporting 0% on new code.
Materializing the user's folder on first write into it now creates
only the namespace. The empty root file written by createIfMissing
collided with the root create issued when the parent folder is saved
with its real composition, which returns 409 on MCWS.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mudinthewater mudinthewater added the Falls-Prio Requested or implemented on behalf of moonfall or skyfall, require review by the openmct dev team label Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Falls-Prio Requested or implemented on behalf of moonfall or skyfall, require review by the openmct dev team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant