Repository navigation
Feat 347 snap time conductor - #500
Open
mudinthewater wants to merge 4 commits into
Open
mudinthewater wants to merge 4 commits into
mudinthewater wants to merge 4 commits into
Conversation
Moment's DDD token is unpadded (2016-1); core's DatePicker feeds the date-box string to moment.utc, which rejects it (deprecation warning, Invalid Date, NaN calendar). DDDD zero-pads (2016-001), matching FORMAT.
Independent time-conductor toggle left of 'Filter By Selected Sessions' (plot clock icon; disabled until a session is selected). Seeding uses the earliest start / latest end across selections (EOD when equal, start+86400 for SCLK); bounds are editable via the core fixed-inputs popup, applied to the main conductor on filter, and never persisted. Generalized per time system with per-system unavailable tooltips; realtime shows 'Not available in realtime'. Replaces the silent ERT-only auto-snap. Session table gains ERT-labeled plus active-system time column pairs.
Collaborator
Author
|
Also note this one has to have the zero pad fix or the calendar doesn't work in it either. |
|
Collaborator
Author
|
Also resolves #72 72 |
Collaborator
Author
|
Also resolves #29 at least partially. |
mudinthewater
added
the
Falls-Prio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #347 . Implements a time conductor popup that's similar to both the independent time conductor and the regular time conductor input. The initial bounds are chosen based on the largest and smallest values in the selected session ranges.
Note that chill_get_sessions doesn't actually include the new fields, start_time_scet/end_time_scet, start_time_sclk,end_time_sclk so this feature will be limited to ERT for those using MCWS as the endpoint, but those using other datasources such as TSDB, elasticsearch, or chillax can choose to implement the extra fields on the session return.