Repository navigation
Fix persistence provider bugs affecting new user logins - #475
Merged
Merged
Conversation
Collaborator
Author
|
Also fixes #446 |
jvigliotta
force-pushed
the
fix-205-new-user-logins
branch
from
September 28, 2026 22:51
7d38937 to
b1603d1
Compare
- createIfMissing() called this.create(model) to persist a newly created namespace's folder object, which only exists on MCWSPersistenceProvider. MCWSUserContainerProvider inherits createIfMissing() but never implemented create(), so a brand-new user's namespace was created in MCWS but its folder object was never persisted, throwing "this.create is not a function". Persist directly through the already-in-scope namespace handle instead. - persistenceNamespaceKeys was derived only from non-user namespace configs, so a user's leaf folder (e.g. s6a_users-clgarcia) was only claimed by MCWSPersistenceProvider.appliesTo() when a differently- configured shared namespace happened to share the same key prefix. Derive it from all namespace configs instead; the user container node stays excluded via the existing invalidNamespaceKeys exact- match check. - MCWSPersistenceProvider caches its namespace list for the lifetime of the provider instance. When a second user's namespace is created in a different session after the first session's cache was already populated, the first session never finds it and throws a plain TypeError, surfacing as an "Error: <keystring>" placeholder object in the tree until the page is reloaded. Refresh the cache once on a lookup miss before giving up.
jvigliotta
force-pushed
the
fix-205-new-user-logins
branch
from
October 7, 2026 22:19
b1603d1 to
93b1c77
Compare
davetsay
reviewed
Oct 16, 2026
| return namespace.key === persistenceSpace; | ||
| }); | ||
|
|
||
| if (!persistenceNamespace) { |
Collaborator
There was a problem hiding this comment.
always better to check for existence and not a truthy statement
Collaborator
Author
There was a problem hiding this comment.
Is that supposed to be the plan? cause we have ! everywhere in here lol
Collaborator
There was a problem hiding this comment.
I think this is ok, we definitely do this elsewhere, even though it's not the best way to go about it. But, I will update it to be if (persistenceNamespace === undefined) to be more clear. We only act if it's undefined.
Collaborator
There was a problem hiding this comment.
yes we do this elsewhere but we probably shouldn't in most cases
davetsay
reviewed
Oct 16, 2026
Collaborator
|
@jvigliotta , @mudinthewater , i added a couple of comments but this looks good otherwise. good job |
|
davetsay
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createIfMissing() called this.create(model) to persist a newly created namespace's folder object, which only exists on MCWSPersistenceProvider. MCWSUserContainerProvider inherits createIfMissing() but never implemented create(), so a brand-new user's namespace was created in MCWS but its folder object was never persisted, throwing "this.create is not a function". Persist directly through the already-in-scope namespace handle instead.
persistenceNamespaceKeys was derived only from non-user namespace configs, so a user's leaf folder (e.g. s6a_users-clgarcia) was only claimed by MCWSPersistenceProvider.appliesTo() when a differently- configured shared namespace happened to share the same key prefix. Derive it from all namespace configs instead; the user container node stays excluded via the existing invalidNamespaceKeys exact- match check.
MCWSPersistenceProvider caches its namespace list for the lifetime of the provider instance. When a second user's namespace is created in a different session after the first session's cache was already populated, the first session never finds it and throws a plain TypeError, surfacing as an "Error: " placeholder object in the tree until the page is reloaded. Refresh the cache once on a lookup miss before giving up.
Fixes #205