Repository navigation
MMGIS 5.5.5 release: changelog, locked plugin dependency installs, auth:migrate on released databases - #1167
Closed
devin-ai-integration[bot] wants to merge 3 commits into
Closed
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
…endencies install-plugin-deps ran npm install --no-package-lock, which re-resolved the whole tree (about 470 packages changed, including postcss-minify-selectors 7.0.6 -> 7.1.2, which breaks the Layers tool's settings and download panel selectors in production builds). Drop the flag so the lockfile is read, omit dev dependencies in the Docker runtime stage, and fail CI and the Docker build if installed packages differ from package-lock.json. Co-Authored-By: tariq.k.soliman <tariqksoliman@gmail.com>
5.2.24 and earlier have no missions_viewing column; the legacy import selected it unconditionally, so auth:migrate (and its --dry-run) failed on any released database. Select only the legacy columns that exist, and run the CLI import in CI against a database seeded by 5.2.24. Co-Authored-By: tariq.k.soliman <tariqksoliman@gmail.com>
Co-Authored-By: tariq.k.soliman <tariqksoliman@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
developmentat Add AUTH_TOKENS, per-account API token limits, and a main-site API token menu #1164 (c54c70f): the changelog since 5.2.24 (the last tagged release; 5.4.0 is folded in) plus the two release blockers found during release testing.scripts/install-plugin-deps.jsrannpm install --no-package-lock, which re-resolved the whole dependency tree duringnpm ci's postinstall and movedpostcss-minify-selectorsfrom the locked 7.0.6 to 7.1.2. 7.1.2 minifies theli.download_on .layerExport, li.gears_on .settingsrule inLayersTool.cssinto an:is(...)selector that matches nothing.npm run auth:migrate, including--dry-run, crashed on any database from 5.2.24 or earlier withcolumn "missions_viewing" does not exist.legacyImport.plan()selected that column unconditionally, but it's only added by the Users plugin's startupALTER TABLE, and it arrived after 5.2.24.Proposed Changes
scripts/install-plugin-deps.js: drop--no-package-lockand keep--no-save, so npm reads the lockfile and only adds the plugin packages.Dockerfile: the runtime stage runs the plugin install withnpm_config_omit=dev, so reading the lockfile doesn't pull dev dependencies into the image. The builder stage also runs the new lockfile check.scripts/check-installed-lockfile.js: exits non-zero if any installed package innode_modulesdiffers frompackage-lock.json. It runs in the Docker builder stage and in CI afternpm ci.API/permissions/legacyImport.js:plan()reads theuserscolumns withUser.describe()and selects only the legacy mission columns that exist. A missingmissions_viewingis treated as unset, which matches how those databases behaved. Dry runs still don't change the database.tests/migration/run-legacy-compat.sh:APPLY_WITH=cliruns the import withnpm run auth:migratebefore the upgraded server starts. The default still lets the server import on first start.playwright-tests.yml): a step runningAPPLY_WITH=cli bash tests/migration/run-legacy-compat.sh 5.2.24against a database seeded by the 5.2.24 tag, plus the lockfile check afternpm ci.tests/unit/permissions-legacyImport.spec.js: a test for auserstable withoutmissions_viewing.CHANGELOG.md: one## 5.5.5section covering everything since 5.2.24, replacingUnreleasedand the untagged5.4.0. The date is stillNovember XXand will be set when the release is tagged.CITATION.cffandAGENTS.mdversion references are set to 5.5.5.Issues
Testing
tests/unit: 1779 passed.npm ciwith the postinstall:postcss-minify-selectorsstays at 7.0.6, andnode scripts/check-installed-lockfile.jspasses.npm run buildsucceeds, andtests/e2e/map/dynamic-style.spec.jspasses 7/7. Two of those tests failed on the release-test build.docker build:webpack) and hasldapts9.2.0, which isrequire-able.#layersToolList>li.download_on .layerExport,#layersTool #layersToolList>li.gears_on .settings{.tests/migration/run-legacy-compat.sh):5.2.24, it passes both with the server import (default) and withAPPLY_WITH=cli.10d74e11^) still passes.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/f6e20e2ef1744cf4892c180a45852830
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/f6e20e2ef1744cf4892c180a45852830?variant=devin
Requested by: @tariqksoliman