Package pages for packages without MVR names - #251
Draft
mdgeorge4153 wants to merge 4 commits into
Draft
Conversation
A package with no MVR name (e.g. a system package like the Sui Bridge at 0xb, which Certora has audited) previously 404'd — there was no way to see the attestations, versions, or dependents that are known about it on-chain. Resolve a bare `/package/0x…` URL into a nameless `ResolvedName` via `useResolvePackageByAddress` (on-chain `packageVersions` + `asMovePackage`), routed through a new `useResolvePackage` that the page and layout use in place of `useResolveMvrName`. The name-keyed version enumeration (`useGetMvrVersionAddresses`) grows an address branch so the Versions, Dependents, and Attestations tabs work with no server-side changes; the dependents *count* badge (name-keyed analytics) is the one surface that stays empty for nameless packages. The Readme tab becomes an "unregistered package" landing placeholder, and the header shows the truncated address as the title. Unnamed dependencies and nameless attestation subjects now link to their by-address pages just like named ones do. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GqiELJtBuhYBp2W35ExHCk
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The Security tab renders one audit section per package version. Attestations are keyed by the subject *address*, though, and a system package (the bridge at 0xb) keeps one address across all its upgrades — so its single Certora audit was rendering once per version (8×). Collapse versions to one section per distinct address, keeping the newest version as the representative; normal packages, whose versions have distinct addresses, are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GqiELJtBuhYBp2W35ExHCk
`mvr add` takes an MVR name, so `mvr add 0x…` is not a valid install command. Omit the Install section entirely for a package with no name. (The sidebar's Analytics block already self-hides for these, and Source Code is gated on git_info, so only the Description remains.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GqiELJtBuhYBp2W35ExHCk
An attester without an MVR name (e.g. Certora) rendered a non-clickable address. Now that /package/<address> resolves, link it to its by-address page — where its Attestations tab lists what it has attested — instead of showing a dead address. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GqiELJtBuhYBp2W35ExHCk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #247 (
mdgeorge/source-verification-2-sv-display).What
Packages with no MVR name previously returned "Package not found" — there was no
way to view what's known about them on-chain. The motivating case: Certora
audited the Sui Bridge (
0xb), a system package that will never have an MVRname, and that attestation was invisible in the UI.
This resolves a bare
/package/0x…URL into a namelessResolvedNameand rendersthe package's on-chain surfaces.
How
useResolvePackageByAddressresolves an address to a minimalResolvedName(
name= the address; nogit_info/metadata/package_info) viapackageVersionsasMovePackage. A newuseResolvePackagebranches name-vs-address andreplaces
useResolveMvrNamein the package page and layout.useGetMvrVersionAddressesgrows an address branch (packageVersionsGraphQL)so the Versions, Dependents, and Attestations tabs work with no
server-side changes — dependents are already fetched by
/v1/package-address/….header shows the truncated address as the title.
by-address pages, just like named ones.
Try it
/package/0xbon testnet → Security tab shows Certora's Sui Bridge audit.(The derived attestation box for
0xbwas verified to own Certora's attestation.)Known limits (MVP)
empty for nameless packages — the tab panel itself works. Fixing the count needs
a server-side (analytics-by-address) change; deferred by design.
0xbresolves on both networks and defaults to mainnet (empty Security there);toggle to testnet to see the audit.
views list one entry per version number at the same address (cosmetic).
🤖 Generated with Claude Code