Repository navigation
Inherit SampleSurfaces in the reco RegrowLH - #606
Conversation
RegrowLH overrides SampleSurfaces, so add TS5_Face to match the Offline LHDriftFit default (Mu2e/Offline#2152). Requires that Offline PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Hi @michaelmackenzie,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for ab896bd: build (Build queue - API unavailable) |
|
☀️ The build tests passed at ab896bd.
N.B. These results were obtained from a build of this Pull Request at ab896bd after being merged into the base branch at 7672e81. For more information, please check the job page here. |
oksuzian
left a comment
There was a problem hiding this comment.
PR Review Summary — #606
Reviewed at head ab896bddc5c79fdcadf9784b482cb5168600efca. First pass.
Decision
- 🟢 approve. The change is correct and makes the reco
RegrowLHsample the same surfaces as the Offline drift fits after Mu2e/Offline#2152. I suggest one simpler alternative below. It does not block.
Scope understood
- One line:
JobConfig/reco/prolog.fcl:134addsTS5_FacetoSampleSurfacesinReconstruction.producers.RegrowLH. - This module inherits
@table::Mu2eKinKal.producers.KKDe.KKFitSettingsand then overridesSampleSurfaces.
Findings
- 🟡 [S2] Delete the override instead of editing it.
- Evidence: the overriding list is the same as the inherited one, with Offline
mainand with Offline#2152. I deleted the line and printed the resulting value withfhicl-dump. With Offlinemainit is["ST_Outer","ST_Front","ST_Back"], the same as now. With Offline#2152 it is["ST_Outer","ST_Front","ST_Back","TS5_Face"], the same as this PR. - Suggested fix: remove the
SampleSurfacesline. The module then follows the Offline default, the merge order no longer matters, and the two lists cannot drift apart later.
- Evidence: the overriding list is the same as the inherited one, with Offline
Validation check
- 🟢 Config contract. I ran
fhicl-dumpon 1133 files from Offline, Production, EventNtuple and mu2e-trig-config, with this PR and without it, on Offlinemainwith Offline#2152 merged. 97 configs differ, and only inphysics.producers.RegrowLH.KKFitSettings.SampleSurfaces, which gainsTS5_Face. No other key changes. - 🟢 Merge order. In none of those 97 configs is
RegrowLHon a path, and art does not build modules that are on no path. I ran the committedreco/OnSpill.fclon 20 CE events with this PR on Offlinemain(no #2152). It finished with exit code 0. So merging this PR before Offline#2152 breaks no committed job. The note in the PR body is true only for a job that schedules this module. - This module cannot be scheduled as written, at base or with Offline#2152. When I added it to the reco path, art stopped with "Module with label RegrowLH of type RegrowLoopHelix is configured as a producer but defined in code as a filter." It also sets neither
MustRegrownorKalSeedCollection, andRegrowLoopHelixrequires both (Mu2eKinKal/src/RegrowLoopHelix_module.cc:99and:196). That is older than this PR and is not its job to fix.- With those three things fixed, the module runs with Offline#2152 (exit code 0). On Offline
mainit stops at construction with "SurfaceIdEnum invalid enum name : TS5_Face", as the PR body says.
- With those three things fixed, the module runs with Offline#2152 (exit code 0). On Offline
- 🟢 This is the only
SampleSurfacesoverride in Production. The other regrow configs take theirs from Offline.reco/regrowLH.fclusesMu2eKinKal.RegrowLH, which Offline#2152 updates.reco/regrowKL.fcluses the KinematicLine settings, which never sampleTS5_Face. - FNALbuild build 716 passed at ab896bd (16:13 UTC), merged onto Production
main7672e81 with Offlinemain. Offline#2152 build 3638, which included this PR, passed every test at 17:36 UTC.
Residual risk
- None for production jobs today, because no committed job runs this module.
Author follow-ups
- Optional: delete the
SampleSurfacesline instead (finding 1).
Per review: drop the override instead of editing it. The inherited KKDe list is the same, so RegrowLH follows the Offline default (TS5_Face with Mu2e/Offline#2152) and the merge order no longer matters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks Yuri, done in the latest commit: the |
oksuzian
left a comment
There was a problem hiding this comment.
PR Review Summary — #606
Reviewed at head 35989d9aa29a32d91e4b2b212dd6776679ebca41. Re-review of ab896bd.
Decision
- 🟡 comment now, approve when green. The new commit does what my finding 1 suggested, and the value is right with and without Offline#2152. FNALbuild has not run at this head yet, so I have asked for a build.
What changed since ab896bd
- One commit. It deletes the
SampleSurfacesline fromReconstruction.producers.RegrowLH.KKFitSettingsinJobConfig/reco/prolog.fcl, so the module takes the list from@table::Mu2eKinKal.producers.KKDe.KKFitSettings. Againstmain, the PR now removes one line and adds none.
Prior findings
- 🟢 [was S2] Delete the override instead of editing it. FIXED in 35989d9, verified.
JobConfig/reco/prolog.fclat this head is byte-identical to the copy with the line deleted that I checked in my first pass.- I re-ran
fhicl-dumponReconstruction.producers.RegrowLH.KKFitSettings.SampleSurfaces:- with Offline
main(554ef9f9) it is["ST_Outer","ST_Front","ST_Back"], the same as Productionmaintoday; - with Offline#2152 (62591297) it is
["ST_Outer","ST_Front","ST_Back","TS5_Face"].
- with Offline
- So the two PRs can merge in either order, as the description now says.
Validation check
- Config contract check: pass, by the
fhicl-dumpabove. No other key in the file changes. - FNALbuild:
mu2e/buildtestat this head reads "This test has not been triggered yet" (18:12 UTC on 17 November). The build at ab896bd passed at 16:13 UTC. I have asked for a build at this head; I will approve when it passes.
Residual risk
- None for committed jobs: as in my first pass, no committed configuration schedules this module.
|
@FNALbuild run build test |
|
⌛ The following tests have been triggered for 35989d9: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 35989d9.
N.B. These results were obtained from a build of this Pull Request at 35989d9 after being merged into the base branch at 7672e81. For more information, please check the job page here. |
Companion to Mu2e/Offline#2152.
The reco
RegrowLHinJobConfig/reco/prolog.fcloverrodeSampleSurfaceswith the same list it inherits fromKKDe. This PR removes the override, so the module follows the Offline default:["ST_Outer","ST_Front","ST_Back"]with Offlinemain, and the same plusTS5_Facewith Mu2e/Offline#2152. With Offline#2152,fhicl-dumpgives["ST_Outer","ST_Front","ST_Back","TS5_Face"]. The two PRs can merge in either order.🤖 Generated with Claude Code