Skip to content

Inherit SampleSurfaces in the reco RegrowLH - #606

Merged
oksuzian merged 2 commits into
Mu2e:mainfrom
michaelmackenzie:sample-ts5-face
Nov 17, 2026
Merged

oksuzian merged 2 commits into
Mu2e:mainfrom
michaelmackenzie:sample-ts5-face

Conversation

@michaelmackenzie

@michaelmackenzie michaelmackenzie commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Companion to Mu2e/Offline#2152.

The reco RegrowLH in JobConfig/reco/prolog.fcl overrode SampleSurfaces with the same list it inherits from KKDe. This PR removes the override, so the module follows the Offline default: ["ST_Outer","ST_Front","ST_Back"] with Offline main, and the same plus TS5_Face with Mu2e/Offline#2152. With Offline#2152, fhicl-dump gives ["ST_Outer","ST_Front","ST_Back","TS5_Face"]. The two PRs can merge in either order.

🤖 Generated with Claude Code

RegrowLH overrides SampleSurfaces, so add TS5_Face to match the Offline
LHDriftFit default (Mu2e/Offline#2152). Requires that Offline PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @michaelmackenzie,
You have proposed changes to files in these packages:

  • JobConfig

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for ab896bd: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at ab896bd.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged ab896bd at 7672e81
build (prof) ✅ Log file. Build time: 04 min 37 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at ab896bd after being merged into the base branch at 7672e81.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #606

Reviewed at head ab896bddc5c79fdcadf9784b482cb5168600efca. First pass.

Decision

  • 🟢 approve. The change is correct and makes the reco RegrowLH sample the same surfaces as the Offline drift fits after Mu2e/Offline#2152. I suggest one simpler alternative below. It does not block.

Scope understood

  • One line: JobConfig/reco/prolog.fcl:134 adds TS5_Face to SampleSurfaces in Reconstruction.producers.RegrowLH.
  • This module inherits @table::Mu2eKinKal.producers.KKDe.KKFitSettings and then overrides SampleSurfaces.

Findings

  1. 🟡 [S2] Delete the override instead of editing it.
    • Evidence: the overriding list is the same as the inherited one, with Offline main and with Offline#2152. I deleted the line and printed the resulting value with fhicl-dump. With Offline main it is ["ST_Outer","ST_Front","ST_Back"], the same as now. With Offline#2152 it is ["ST_Outer","ST_Front","ST_Back","TS5_Face"], the same as this PR.
    • Suggested fix: remove the SampleSurfaces line. The module then follows the Offline default, the merge order no longer matters, and the two lists cannot drift apart later.

Validation check

  • 🟢 Config contract. I ran fhicl-dump on 1133 files from Offline, Production, EventNtuple and mu2e-trig-config, with this PR and without it, on Offline main with Offline#2152 merged. 97 configs differ, and only in physics.producers.RegrowLH.KKFitSettings.SampleSurfaces, which gains TS5_Face. No other key changes.
  • 🟢 Merge order. In none of those 97 configs is RegrowLH on a path, and art does not build modules that are on no path. I ran the committed reco/OnSpill.fcl on 20 CE events with this PR on Offline main (no #2152). It finished with exit code 0. So merging this PR before Offline#2152 breaks no committed job. The note in the PR body is true only for a job that schedules this module.
  • This module cannot be scheduled as written, at base or with Offline#2152. When I added it to the reco path, art stopped with "Module with label RegrowLH of type RegrowLoopHelix is configured as a producer but defined in code as a filter." It also sets neither MustRegrow nor KalSeedCollection, and RegrowLoopHelix requires both (Mu2eKinKal/src/RegrowLoopHelix_module.cc:99 and :196). That is older than this PR and is not its job to fix.
    • With those three things fixed, the module runs with Offline#2152 (exit code 0). On Offline main it stops at construction with "SurfaceIdEnum invalid enum name : TS5_Face", as the PR body says.
  • 🟢 This is the only SampleSurfaces override in Production. The other regrow configs take theirs from Offline. reco/regrowLH.fcl uses Mu2eKinKal.RegrowLH, which Offline#2152 updates. reco/regrowKL.fcl uses the KinematicLine settings, which never sample TS5_Face.
  • FNALbuild build 716 passed at ab896bd (16:13 UTC), merged onto Production main 7672e81 with Offline main. Offline#2152 build 3638, which included this PR, passed every test at 17:36 UTC.

Residual risk

  • None for production jobs today, because no committed job runs this module.

Author follow-ups

  1. Optional: delete the SampleSurfaces line instead (finding 1).

Per review: drop the override instead of editing it. The inherited KKDe list
is the same, so RegrowLH follows the Offline default (TS5_Face with
Mu2e/Offline#2152) and the merge order no longer matters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michaelmackenzie michaelmackenzie changed the title Sample TS5_Face in the reco RegrowLH Inherit SampleSurfaces in the reco RegrowLH Nov 17, 2026
@michaelmackenzie

Copy link
Copy Markdown
Contributor Author

Thanks Yuri, done in the latest commit: the SampleSurfaces override is removed, so RegrowLH inherits the KKDe list. With Offline#2152, fhicl-dump gives ["ST_Outer","ST_Front","ST_Back","TS5_Face"]. The PR body is updated, and merge order no longer matters.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #606

Reviewed at head 35989d9aa29a32d91e4b2b212dd6776679ebca41. Re-review of ab896bd.

Decision

  • 🟡 comment now, approve when green. The new commit does what my finding 1 suggested, and the value is right with and without Offline#2152. FNALbuild has not run at this head yet, so I have asked for a build.

What changed since ab896bd

  • One commit. It deletes the SampleSurfaces line from Reconstruction.producers.RegrowLH.KKFitSettings in JobConfig/reco/prolog.fcl, so the module takes the list from @table::Mu2eKinKal.producers.KKDe.KKFitSettings. Against main, the PR now removes one line and adds none.

Prior findings

  1. 🟢 [was S2] Delete the override instead of editing it. FIXED in 35989d9, verified.
    • JobConfig/reco/prolog.fcl at this head is byte-identical to the copy with the line deleted that I checked in my first pass.
    • I re-ran fhicl-dump on Reconstruction.producers.RegrowLH.KKFitSettings.SampleSurfaces:
      • with Offline main (554ef9f9) it is ["ST_Outer","ST_Front","ST_Back"], the same as Production main today;
      • with Offline#2152 (62591297) it is ["ST_Outer","ST_Front","ST_Back","TS5_Face"].
    • So the two PRs can merge in either order, as the description now says.

Validation check

  • Config contract check: pass, by the fhicl-dump above. No other key in the file changes.
  • FNALbuild: mu2e/buildtest at this head reads "This test has not been triggered yet" (18:12 UTC on 17 November). The build at ab896bd passed at 16:13 UTC. I have asked for a build at this head; I will approve when it passes.

Residual risk

  • None for committed jobs: as in my first pass, no committed configuration schedules this module.

@oksuzian

Copy link
Copy Markdown
Collaborator

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 35989d9: build (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 35989d9.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 35989d9 at 7672e81
build (prof) ✅ Log file. Build time: 04 min 40 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 35989d9 after being merged into the base branch at 7672e81.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian
oksuzian merged commit 3cab8cd into Mu2e:main Nov 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants