Skip to content

Schedule the track-CRV association (TrkCrvMatcher, TrkCrvMatchMCMaker) in the reco and recoMC paths - #595

Merged
oksuzian merged 6 commits into
Mu2e:mainfrom
RobMina:trkcrv-match
Nov 22, 2026
Merged

oksuzian merged 6 commits into
Mu2e:mainfrom
RobMina:trkcrv-match

Conversation

@RobMina

@RobMina RobMina commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR runs the Offline track-CRV association (Mu2e/Offline#2106) in the standard reconstruction, so that
production reco output carries one TrkCrvMatch collection per KalSeed collection, and recoMC output also its
TrkCrvMatchMC truth. Analyses, the EventNtuple (Mu2e/EventNtuple#441) and the nightly validation
(ValTrkCrvMatch, Mu2e/Offline#2107) then read the association instead of building it themselves.

Changes

JobConfig/reco/prolog.fcl:

  • one TrkCrvMatcher instance per KalSeed collection, from the Offline prolog table:
    • TrkCrvMatchLine (KKLine) and TrkCrvMatchCHmu (KKCHmu): time and geometric matching, layer probe on;
    • TrkCrvMatchDe, TrkCrvMatchUe, TrkCrvMatchDmu, TrkCrvMatchUmu: time only, since LoopHelix fits do not
      reach the CRV;
    • DtRefCenter per instance, the median dtRef of each track's own cluster in MC truth for that fit (Offline#2106):
      KKCHmu 27 ns, KKDe 32, KKUe 28, KKDmu 30, KKUmu 26 (MDC2025au CosmicSignalOffSpill CH and LH reco); KKLine uses
      the Offline default, 13 ns;
    • SigmaV : [ 13 ] (mm) on TrkCrvMatchLine and TrkCrvMatchCHmu: the Offline SigmaV list is per CRV sector type
      of the extracted geometry (EX, T1, T2, muon taggers = types 1-4), while in the Run1 geometries (geom_common.txt,
      Run1B) T1 and T2 are both type 1 and would take the EX value, 7 mm. One provisional value for type 1, the
      extracted T1 value, until a Run1 tuning; it changes only the pulls and the best-candidate flags of the geometric
      candidates, not which candidates are kept;
  • each runs after SelectReco, on its selected clusters, while the full CrvRecoPulses are still in the event for
    the layer probe;
  • sequences added at the end of the paths: NoFieldPath (line), OnSpillPath (the four LoopHelix fits),
    CentralHelixPath and LoopHelixPath (central helix and the four LoopHelix fits);
  • keep mu2e::TrkCrvMatchs_*_*_* in the high-level reco products.

JobConfig/reco/Extracted.fcl, JobConfig/recoMC/Extracted.fcl: TrkCrvMatchLine.SigmaV back to the Offline
per-sector-type list (@local::TrkCrvMatcher.SigmaV), since these jobs use the extracted geometry.

JobConfig/recoMC/prolog.fcl:

  • one TrkCrvMatchMCMaker per matcher (TrkCrvMatch<fit>MC), after the MC reco sequence, since it needs
    compressRecoMCs and CrvCoincidenceClusterMCAssns;
  • the same per-path sequences, and keep mu2e::TrkCrvMatchMCs_*_*_*.

No other module, filter or output selection changes.

Tests

On a build of Offline with the association PR:

  • recoMC/Extracted.fcl from MDC2025bb digis (extracted v06 geometry), 300 events: the line matcher and its
    truth run in NoFieldPath, and both products are in the output.
  • recoMC/OnSpill.fcl from MDC2025au FlatGammaMix1BB digis, 200 events: the four LoopHelix matchers and their
    truth run in OnSpillPath, both products are in the output, and every track of every collection has truth
    (52, 51, 44 and 46 tracks).
  • SigmaV per configuration (fhicl-dump with and without the SigmaV change): TrkCrvMatchLine keeps
    [7, 13, 7, 17] in reco/Extracted, recoMC/Extracted and recoMC/ExtractedAllEvents, where nothing else that
    runs changes; TrkCrvMatchLine and TrkCrvMatchCHmu get [13] in reco and recoMC NoField, NoFieldRun1B,
    OffSpill and OnSpill.
  • CPU (OnSpill): 9-19 µs per event for each matcher and 40-220 µs for each truth module, against 68 ms per event
    for the whole job.

Notes

  • Truth summaries: each TrkCrvMatchMCMaker prints its end-of-job summary, so a recoMC job prints one per
    instance. Set PrintSummary : false in the recoMC prolog if that is too verbose for production logs.
  • Blinding: a stream that strips the CRV clusters must also drop TrkCrvMatchs, whose Ptrs would dangle.

🤖 Generated with Claude Code

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @RobMina,
You have proposed changes to files in these packages:

  • JobConfig

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 56523f1: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@RobMina
RobMina marked this pull request as draft November 6, 2026 03:23
@FNALbuild

Copy link
Copy Markdown
Collaborator

☔ The build tests failed for 56523f1.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 56523f1 at 94a4d81
build (prof) ✅ Log file. Build time: 04 min 34 sec
ceSimReco ❌ Log file. Return Code 90.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ❌ Log file. Return Code 90.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 56523f1 after being merged into the base branch at 94a4d81.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian

oksuzian commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator

One configuration point from a static review of Offline/CRVReco at main b6462a047, which includes #2106.

The six TrkCrvMatcher instances this PR adds to JobConfig/reco/prolog.fcl (TrkCrvMatchLine, TrkCrvMatchCHmu, TrkCrvMatchDe, TrkCrvMatchUe, TrkCrvMatchDmu, TrkCrvMatchUmu) all keep the Offline default resolution lists:

SigmaV : [ 7, 13, 7, 17 ]   # mm, per CRV sector type, type 1 first

CRVReco/fcl/prolog_v12.fcl:412-416 says these lists are for the extracted geometry's sector types (EX = 1, T1 = 2, T2 = 3, muon taggers = 4; crv_counters_extracted_v04.txt), and that other geometries need their own lists. TrkCrvMatchTool.cc:39-41 looks them up by sectorType - 1 and clamps to the last entry.

Production's default geometry (common/epilog.fcl:10, geom_common.txt) resolves to geom_run1_a_stickman.txt and crv_counters_run1a_v01.txt, where T1 and T2 are both sector type 1. So with this PR, Run1A reco takes the V resolution of both T1 and T2 from the extracted EX entry, 7 mm. The extracted tuning gave T1 13 mm. DtRefCenter is already set per instance here, so SigmaV (and SigmaU/SigmaT if they differ) could be set the same way for the Run1A geometry. Alternatively, the module could refuse a geometry whose sector types the lists do not describe.

SigmaV enters the geometric chi2 (TrkCrvMatchTool.cc:274-282), which ranks candidates and sets the bestInSector, bestForTrack and bestForCluster flags (:302-348). This PR sets DoGeometric : false for De, Ue, Dmu and Umu, so only TrkCrvMatchLine and TrkCrvMatchCHmu are affected. The prolog describes the windows as loose storage windows, so which candidates are kept does not change. Their stored pulls and best-candidate flags do. I did not check what the right Run1A values are.

@RobMina

RobMina commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 7b06260: build (Build queue - API unavailable)

@RobMina
RobMina marked this pull request as ready for review November 10, 2026 14:50
@RobMina

RobMina commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @oksuzian , that's a good catch: in crv_counters_run1a_v01.txt T1 and T2 are both sector type 1, so with the Offline default both took the EX entry, 7 mm. Run1B (geom_run1_b_v40.txt) includes the same CRV file.

Fixed in 7b06260:

  • JobConfig/reco/prolog.fcl: TrkCrvMatchLine and TrkCrvMatchCHmu set SigmaV : [ 13 ], one value for sector type
    1, the T1 value of the extracted tuning. It is provisional until there is a Run1 tuning. SigmaU and SigmaT are
    single-entry lists already, so they apply to every sector type.
  • JobConfig/reco/Extracted.fcl and JobConfig/recoMC/Extracted.fcl: these jobs use the extracted geometry, so they
    restore the Offline per-sector-type list for the line matcher
    (physics.producers.TrkCrvMatchLine.SigmaV : @local::TrkCrvMatcher.SigmaV).

Checked with fhicl-dump, with and without the change:

  • in reco/Extracted, recoMC/Extracted and recoMC/ExtractedAllEvents, TrkCrvMatchLine keeps [7, 13, 7, 17];
  • in the reco and recoMC NoField, NoFieldRun1B, OffSpill and OnSpill configurations, TrkCrvMatchLine and
    TrkCrvMatchCHmu get [13].

The LoopHelix instances are time only and do not use SigmaV. EventNtuple#441 runs its own TrkCrvMatchCHmu on Run1
reco files, so it gets the same setting.

Making the module refuse a geometry whose sector types the lists do not describe is a better long-term guard. That is
an Offline change, so I would do it as a follow-up PR rather than here.

Now that Offline#2106 is merged, this PR is ready for review.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 7b06260.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 7b06260 at bcfef27
build (prof) ✅ Log file. Build time: 09 min 28 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 7b06260 after being merged into the base branch at bcfef27.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #595

Reviewed at head 7b062601b37975c63590120ae0b80d436a36fa31. First pass.

Decision

  • 🟢 approve. The association runs in the reco and recoMC paths as described. It costs about 2% of the off-spill reco time and 0.4% of the output file, and it changes no other product. FNALbuild build 705 passed every test at this head. The SigmaV point from my comment of Nov 9 is fixed. Two configurations do not get the association: Run 1B no-field reco (finding 1), and the nightly off-spill and reco validation outputs, which drop it (finding 2). Neither blocks.

Scope understood

  • Six TrkCrvMatcher instances, one per KalSeed collection, run after SelectReco: KKLine in NoFieldPath, the four LoopHelix fits in OnSpillPath, and KKCHmu plus the LoopHelix fits in both off-spill paths. The LoopHelix ones are time only. recoMC adds the six TrkCrvMatchMCMaker instances after MCReco. The default outputs keep TrkCrvMatchs and TrkCrvMatchMCs.

Prior findings (my comment of 2026-11-09)

  • 🟢 [was a comment] All six instances kept the extracted geometry's SigmaV list, so Run 1 reco took T1's and T2's V resolution from the EX entry. FIXED in 7b06260, verified with fhicl-dump. TrkCrvMatchLine and TrkCrvMatchCHmu have SigmaV: [13] in reco and recoMC NoField and OffSpill (and their retrigger variants). Both Extracted configurations keep [7, 13, 7, 17].

Findings

  1. 🟡 [S2] recoMC/NoFieldRun1B.fcl defines its own physics.RecoPath as an explicit module list, so it schedules neither TrkCrvMatchLine nor TrkCrvMatchLineMC.
    • Evidence: at this head merged with main, fhicl-dump shows both modules configured (with SigmaV: [13]) but on no path. The list ends at CrvCoincidenceClusterMCAssns (NoFieldRun1B.fcl:104-132 at this head, :111-139 after merging main). Run 1B no-field reco, which has KKLine, ProtonKKLine and CosmicKKLine, therefore writes no association.
    • Suggested fix: append TrkCrvMatchLine and TrkCrvMatchLineMC to that RecoPath, or say in the description that Run 1B no-field reco is left out.
  2. 🟡 [S2] The nightly off-spill and reco validation outputs drop the new products, so the Offline#2107 histograms are never filled there.
    • Evidence: Validation/offSpill.fcl (included by Validation/nightly/offSpill_*.fcl) writes CentralHelixOutput with "drop *_*_*_*" and an explicit keep list that has no TrkCrvMatchs or TrkCrvMatchMCs. Validation/reco.fcl is the same. I ran the committed offSpill.fcl on 300 events and Offline#2107's val.fcl on the output: no TrkCrv directory. Of the validation outputs, only ceSimReco (KKDe only; the others are dropped by "drop *_*Ue*_*_*" and "drop *_*mu*_*_*") and the extracted KinematicLineOutput keep them. The off-spill job is the one whose own comment says it validates the CentralHelix extrapolation to the CRV.
    • Suggested fix: add "keep mu2e::TrkCrvMatchs_*_*_*" and "keep mu2e::TrkCrvMatchMCs_*_*_*" to the offSpill.fcl (and, if wanted, reco.fcl) keep lists.
  3. ⚪ [S3] On my off-spill sample the DtRefCenter values sit 2 to 10 ns above the own-cluster medians that TrkCrvMatchMCMaker prints.
    • Median dtRef of each track's own cluster, 9,314 events, validation setting: KKCHmu 16.9 ns (3,217 clusters; production setting 16.7 ns), KKDe 21.5, KKDmu 21.7, KKUe 24.9 and KKUmu 23.8 ns (24 to 29 clusters each). This PR sets 27, 32, 30, 28 and 26 ns.
    • DtRefCenter only ranks the best time candidate, and on this sample the best time candidate of KKCHmu is the track's own cluster for 3,208 of 3,229 tracks anyway. If your MDC2025au sample gives the PR's values, the difference is between samples; a line naming the sample and its statistics in the prolog comment would help the next tuning.

Checked, no action needed

  • 🟢 Every reco, recoMC and validation configuration still configures: fhicl-dump gives the same 44 of 45 at main and at this head (recoMC/MakeSurfaceSteps aborts at both).
  • 🟢 Nothing else changes. Off-spill reco, main against this head, on the same 3,000 events: the Offline val.fcl histograms of every other product agree bin for bin (1,293 histograms). The one exception is the TriggerResults index histogram.
  • 🟢 Cost and size. TimeTracker, production off-spill setting: the matcher and truth modules together take 0.41 ms per event, 2.3% of the event time. On-spill ceMix recoMC: 0.5%. product_sizes_dumper: the new collections are 0.4% of the off-spill file and about 0.1% of the ceMix file.
  • 🟢 The products are usable downstream. The kept KalSeeds_K* and SelectReco clusters cover the Ptrs. EventNtuple#441, reading TrkCrvMatchCHmu/MC from this output, fills its branches consistently for all 4,876 tracks, with true-crossing deposits (the recoMC instances see the digi CrvSteps).

Validation check

  • Build/tests run: yes. A muse workspace on the CI build ca7b6580_bcfef276_5999ffa2, with this head merged with main 5ae70c7f (clean) and Offline#2107, built with exit status 0. I ran off-spill recoMC on 9,314 events (validation setting) and 3,000 events (production setting) at main and at this head, and on-spill recoMC on 42 ceMix events. All jobs exited with status 0. FNALbuild build 705 (merged on bcfef276) passed every test, including ceSimReco, cosmicSimReco and cosmicOffSpill.
  • Config contract check: pass, apart from findings 1 and 2.
  • Cross-repo consistency: needs Offline#2106 (merged). Offline#2107 and EventNtuple#441 do not need this PR, but #441's ntuple jobs recompute the association, which shadows these products once they are in the files; I raised that on #441.

Author follow-ups

  1. Schedule the association in NoFieldRun1B.fcl, or note why not (finding 1).
  2. Keep the new products in the nightly off-spill validation output (finding 2).
  3. Optional: the sample behind the DtRefCenter values (finding 3).

@oksuzian
oksuzian requested a review from brownd1978 November 10, 2026 17:54

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #595

Reviewed at head 34d293eb34a29b9fbd3ae5130e2411823133fb46. Re-review of 7b06260.

Decision

  • 🟡 comment now, approve when green. The new commit fixes both of my findings and documents the sample behind the DtRefCenter values. FNALbuild has not built this head: mu2e/buildtest is pending and FNALbuild has posted nothing since the push (checked 21:20 UTC). Build 705 passed at 7b062601, and this commit changes only fcl. I am triggering a build and will approve once it is green.

What changed since 7b06260

  • One commit, 34d293e "Address review comments." (4 fcl files, +9 −2). Not a rebase.

Prior findings (from my review at 7b062601)

  • 🟢 [was 🟡 S2] recoMC/NoFieldRun1B.fcl did not schedule the association. FIXED, verified with fhicl-dump: its RecoPath (29 modules) now runs TrkCrvMatchLine right after SelectReco, and TrkCrvMatchLineMC last, after compressRecoMCs and CrvCoincidenceClusterMCAssns, whose products it reads. Both modules are configured as in the other recoMC jobs (SigmaV: [13]; RequireCrvSteps: true with compressDigiMCs steps).
  • 🟢 [was 🟡 S2] The nightly validation outputs dropped the products. FIXED, verified with fhicl-dump: Validation/offSpill.fcl's CentralHelixOutput keeps TrkCrvMatchs_*_*_* and TrkCrvMatchMCs_*_*_*. Validation/reco.fcl keeps TrkCrvMatchDe and TrkCrvMatchDeMC, the association of KKDe, the one fit that output keeps.
  • 🟢 [was ⚪ S3] The DtRefCenter values had no stated sample. Addressed: the prolog comment now names the MDC2025au samples they come from and gives the nightly off-spill input's medians (KKCHmu 24.6 ns, the LoopHelix fits 26.6 to 33.2 ns). My off-spill sample gave lower medians (KKCHmu 16.9 ns), so the right centre depends on the sample; the comment now lets the next tuning start from numbers. DtRefCenter only ranks the best time candidate.

Validation check

  • Build/tests run: fhicl-dump of recoMC/NoFieldRun1B.fcl, Validation/offSpill.fcl and Validation/reco.fcl at this head with Offline main ca7b6580 (exit status 0 for all three). No jobs were rerun: the commit changes only module lists, keep lists and a comment, and my runs at 7b062601 cover the matcher itself.
  • Config contract check: pass.
  • Cross-repo consistency: pass. EventNtuple#441 now gives its ntuple-stage producers their own labels, so it no longer shadows these products.

Residual risk

  • Run 1B no-field recoMC with the association was checked by fhicl-dump only, not run.

@oksuzian

Copy link
Copy Markdown
Collaborator

@FNALbuild run build test

@RobMina

RobMina commented Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Found while testing an Offline follow-up: every reco (non-MC) job stopped on its first event with ProductNotFound for SelectReco:CrvCoincidenceClusterFinder. Reco’s SelectReco writes the CRV clusters with no instance name; only SelectRecoMC uses that instance.

Fixed in cb49c71: the reco matchers read SelectReco, and recoMC sets them back to SelectReco:CrvCoincidenceClusterFinder. reco/OffSpill, reco/NoField and reco/Extracted now run and write TrkCrvMatchs. The recoMC configurations dump identically to before, and five recoMC jobs give bit-identical association products.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #595

Reviewed at head cb49c71afdcb80633f7461eec28ea51eccbb56f1. Re-review of 34d293e.

Decision

  • 🟡 comment now, approve when green. The new commit fixes a real failure that my approval of 34d293eb missed: every non-MC reco job stopped on its first event. The fix is right, and it changes nothing in the MC reco jobs. FNALbuild has not built this head (mu2e/buildtest "not triggered yet", checked 15:20 UTC), so I am requesting a build and will approve once it is green.

What changed since 34d293e

  • One commit, cb49c71 "Fix ProductNotFound for SelectReco:CrvCoincidenceClusterFinder" (JobConfig/reco/prolog.fcl +8 −6, JobConfig/recoMC/prolog.fcl +7). Not a rebase.

The fix, checked

  • 🟢 The diagnosis is right.
    • The data-flavour SelectReco writes its CRV clusters with no instance name (Offline/CommonReco/src/SelectReco_module.cc:131, produces<CrvCoincidenceClusterCollection>()).
    • SelectRecoMC writes one collection per input label (Offline/CommonMC/src/SelectRecoMC_module.cc:179), which here is CrvCoincidenceClusterFinder.
    • So SelectReco:CrvCoincidenceClusterFinder exists only in MC reco.
  • 🟢 fhicl-dump at this head against 34d293eb:
    • In reco/OnSpill.fcl, OffSpill.fcl, NoField.fcl and Extracted.fcl, the six matchers (TrkCrvMatchLine, CHmu, De, Ue, Dmu, Umu) now read CrvCoincidenceClusterCollection : "SelectReco". Nothing else changes.
    • recoMC/OnSpill.fcl, OffSpill.fcl, NoField.fcl, NoFieldRun1B.fcl and Extracted.fcl dump identically to 34d293eb.

Prior findings

  • All findings from my earlier reviews were already fixed or addressed at 34d293eb, and this commit does not touch them.

Findings

  1. ⚪ [S3] Nothing in CI runs a non-MC reco job, which is why this got past FNALbuild and my reviews.
    • FNALbuild build 706 passed at 34d293eb, but its reco jobs (ceSimReco, cosmicSimReco, cosmicOffSpill) and the nightly Validation/reco.fcl and offSpill.fcl are all built on recoMC. My fhicl-dump checks could not see a missing product.
    • A short reco/OnSpill.fcl or reco/OffSpill.fcl job in CI or in the nightly validation would catch the next one. Optional, and not for this PR.

Validation check

  • Build/tests run: fhicl-dump of nine reco and recoMC job files at 34d293eb and at this head, in a muse workdir on the CI build main/7fb240fc_ec057b9e_7b20730e; all exited 0. No jobs were run. Your report that reco/OffSpill, NoField and Extracted now run and write TrkCrvMatchs, and that five recoMC jobs give bit-identical association products, is not re-checked here.
  • Config contract check: pass.
  • Cross-repo consistency: pass. The branch is 9 commits behind main (including Production#600) and merges cleanly.

Residual risk

  • Not run by me: a non-MC reco job at this head.

@oksuzian

Copy link
Copy Markdown
Collaborator

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for cb49c71: build (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at cb49c71.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged cb49c71 at 3d99c5b
build (prof) ✅ Log file. Build time: 04 min 45 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at cb49c71 after being merged into the base branch at 3d99c5b.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #595

Reviewed at head cb49c71afdcb80633f7461eec28ea51eccbb56f1. Follow-up to my comment review at the same head.

Decision

  • 🟢 approve. FNALbuild build 709 built this head, merged on main 3d99c5b9, and every test passed: the prof build, all eleven validation jobs, rootOverlaps and g4surfaceCheck. The FIXME/TODO and clang-tidy rows show nothing. This is the approval my comment review promised once the build was green. Those jobs are all built on recoMC, so the non-MC reco fix itself still rests on the fhicl-dump check and your runs. The optional CI note stays open and does not block.

@brownd1978 brownd1978 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is whether we want Crv association with loop helices.

Comment thread JobConfig/reco/prolog.fcl Resolved
LoopHelix tracks do not intersect the CRV. Keep KKLine and KKCHmu
matchers (and their MC makers) only; remove OnSpill TrkCrvMatch
sequences and Validation/reco.fcl keeps for TrkCrvMatchDe.
@RobMina

RobMina commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

I agree that there is use case for LoopHelix tracks. Dropped TrkCrvMatchDe/Ue/Dmu/Umu (and their MC makers) in 1660c8c; only TrkCrvMatchLine and TrkCrvMatchCHmu remain.

@RobMina

RobMina commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

@FNALbuild run build test

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #595

Reviewed at head 1660c8c0a944cc9ba40f21449a636b65942220bc. Re-review of cb49c71.

Decision

  • 🟡 comment now, approve when green. Thanks, Rob. Dropping the four LoopHelix matchers is clean: in every reco and recoMC job, the only change is that those modules and their truth makers are gone. The two follow-ups below are in the PR description and in EventNtuple, not in this PR's files. FNALbuild has not built this head yet: your 14:45 UTC request had no reply from the bot at 15:00 UTC, and jenkins/ghprb is still pending. I will approve once it is green.

What changed since cb49c71

  • One commit, 1660c8c "Drop LoopHelix TrkCrvMatch instances (agree with brownd1978)": JobConfig/reco/prolog.fcl +7 −14, JobConfig/recoMC/prolog.fcl +2 −12, Validation/reco.fcl −2. Not a rebase.

The change, checked

  • 🟢 fhicl-dump of nine job files (reco/OnSpill, OffSpill, NoField, Extracted; recoMC/OnSpill, OffSpill, NoField, NoFieldRun1B, Extracted) and of Validation/reco.fcl and Validation/offSpill.fcl, at cb49c71 and at this head. All exit 0. With the TrkCrvMatchDe/Ue/Dmu/Umu tables and their ...MC makers taken out of the old dumps, the only remaining differences are those labels leaving the paths, and the two keep lines leaving Validation/reco.fcl. TrkCrvMatchLine and TrkCrvMatchCHmu are unchanged.
  • 🟢 Nothing left in Production names the removed labels, or the removed TrkCrvMatchLH and TrkCrvMatchMCLH sequences (git grep at this head).

Prior findings

  • All earlier findings were fixed or answered by cb49c71, and this commit does not touch them.

Findings

  1. 🟡 [S2] EventNtuple still points users to the reco labels this commit removes. On EventNtuple main (a8e216fb), from your EventNtuple#441, fcl/prolog.fcl:237-238 defines TrkCrvMatchRecoTagsAll : [ "TrkCrvMatchDe", "TrkCrvMatchUe", "TrkCrvMatchDmu", "TrkCrvMatchUmu" ] and the matching TrkCrvMatchRecoMCTagsAll. doc/branches.md:70 and helper/ntuplehelper.py:203 tell users to set these tags "for the LoopHelix fits" on reco files from Production's reco paths. No EventNtuple job uses the two lists today, so nothing breaks at merge, but a user who follows the doc will ask for products that no reco file made after this PR holds. A small EventNtuple PR could drop the two lists and that part of the doc text. By Dave's argument, the ntuple-job LoopHelix matchers (TrkCrvMatchAllPath, used by from_mcs-mockdata_trkcrv.fcl) may be worth dropping too; that is your call.
  2. ⚪ [S3] The PR description still describes the four LoopHelix matchers: its lines 13, 16, 25-26 and 44 list TrkCrvMatchDe to TrkCrvMatchUmu, their DtRefCenter values, "OnSpillPath (the four LoopHelix fits)" and the recoMC test of "the four LoopHelix matchers". Please update it before merge, since it becomes the record of what was merged.

Validation check

  • Build/tests run: fhicl-dump as above, in a muse workdir with Production at each head, backed by SimJob MDC2025be (Offline v13_47_01). No jobs were run. The two matchers that stay have three input tags each in the dumps (their KalSeeds, SelectReco CRV clusters, CrvRecoPulses), none made by the removed modules.
  • Config contract check: pass.
  • Cross-repo consistency: needs follow-up in EventNtuple (finding 1). The branch is 33 commits behind main and merges cleanly.

Residual risk

  • Unchanged: no non-MC reco job has been run in CI.

Author follow-ups

  1. The EventNtuple follow-up in finding 1.
  2. Update the PR description.

@oksuzian

Copy link
Copy Markdown
Collaborator

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 1660c8c: build (already triggered: build) (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 1660c8c.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 1660c8c at f162444
build (prof) ✅ Log file. Build time: 18 min 50 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 1660c8c after being merged into the base branch at f162444.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

oksuzian pushed a commit to Mu2e/Offline that referenced this pull request Nov 20, 2026
With DoGeometric true, TrkCrvMatchTool::beginRun checks SigmaV, SigmaU and SigmaT against the sector types of the loaded CosmicRayShield: one entry for all types, or one per sector type 1 to N; otherwise a CONFIG exception names the list and the geometry's sector types. Follow-up to Mu2e/Production#595.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #595

Reviewed at head 1660c8c0a944cc9ba40f21449a636b65942220bc. Follow-up to my comment review at the same head.

Decision

  • 🟢 approve. FNALbuild has now built this head, merged on main f1624445: the prof build, all eleven validation jobs, rootOverlaps, g4surfaceCheck, the TODO/FIXME check and clang-tidy (0 errors, 0 warnings) passed. This is the approval my comment review promised once the build was green.
  • The two follow-ups from that review do not gate: the EventNtuple tag lists, and the PR description that still lists the four LoopHelix matchers.

@RobMina

RobMina commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

@oksuzian @brownd1978 LoopHelix CRV matchers are dropped (1660c8c0); only KKLine + KKCHmu remain. FNALbuild is green at that head. I don't have merge rights on Mu2e/Production — please merge when convenient.

@brownd1978 brownd1978 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@oksuzian
oksuzian merged commit 0270a00 into Mu2e:main Nov 22, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants