Skip to content

Introduce the concept of a 'near miss' intersection. - #2204

Open
brownd1978 wants to merge 2 commits into
Mu2e:mainfrom
brownd1978:nearmiss
Open

brownd1978 wants to merge 2 commits into
Mu2e:mainfrom
brownd1978:nearmiss

Conversation

@brownd1978

@brownd1978 brownd1978 commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

A near miss is defined using new functionality in KinKal, to calculate the trajectory covariance in-bounds fraction at a surface intersection. This new functionality gives a floating-point value for (effectively) the probability that the extrapolated trajectory actually passed through a material, even if that material wasn't included in the fit, which could be useful in analysis. It also allows refactoring the Crv plane extrapolation. This PR depends on KinKal KFTrack/KinKal#239

Summary of changes in #2204

This PR adds "near miss" intersections to the KinKal extrapolation. A near miss is a material crossing that is out of bounds, but where a configurable fraction of the trajectory's projected position covariance lies inside the surface boundary. It is kept in the track as an inactive material crossing. It is then used to replace the hand-built line projections in TrkCrvMatchTool.

The PR depends on KFTrack/KinKal#239, which provides Intersection::pcov_, inbfrac_ and hascov_, fillPlaneCovariance, the new planeCovariance(time, plane, dirtol) signature, and the Material::extrapolate change for inactive crossings.

1. Near-miss intersections in the extrapolation (Mu2eKinKal)

  • Definition (ExtrapolateSweep):
    • Each SweepTarget has a new nearfrac_ setting (default 0, disabled).
    • A crossing of a target that is normally restricted to in-bounds crossings, but is itself out of bounds, is accepted as a near miss when the in-bounds fraction inbfrac_ is at least nearfrac_. inbfrac_ is the fraction of the projected position covariance inside the surface boundary.
    • ExtrapolateSweep::nearMiss(target, inter) identifies one.
  • Bookkeeping: a near miss does not use up the target's crossing count or its group, so a later in-bounds crossing of the same target or group is still found. It does update the re-crossing guard and the last-crossing state, like any other accepted crossing.
  • Material effect:
    • The KKShellXing for a near miss has no material crossings, so it is inactive. With KinKal#239, Material::extrapolate then leaves the trajectory unsplit and adds no energy loss or scattering.
    • The effect stays in the fit. If a refit moves the crossing back in bounds, its material counts. That mirrors an in-bounds crossing that moves out of bounds and is dropped.
  • Cost controls:
    • The covariance projection for in-bounds crossings is computed only for the winning (earliest) crossing.
    • A near-miss candidate is first screened cheaply: it is rejected if it lies more than 5 sigma outside the boundary, measured with the largest eigenvalue of the projected covariance. boundsFraction runs only for candidates that pass.
    • For targets with near misses enabled, the cylinder axial reach cut in withinReach is skipped, because a near miss can lie past the cylinder's ends. This may add some cost. Tuning it is left for later optimization studies.
  • KKShellXing::updateReference: it asks for the covariance projection when the crossing already has one, so pcov_ and inbfrac_ stay current through refits.
  • KKExtrap:
    • It sets nearfrac_ on the IPA, stopping-target foils, cylinder shells, plane shells and calorimeter panels, and uses a separate value for the CRV sectors. It is not set on calorimeter-support or record-only targets.
    • Near misses do not trigger the momentum-range or time-range stop checks (rangesOut).
    • For a CRV near miss, the layer fraction is evaluated at the closest point inside the sector rectangle.
  • Configuration:
    • KKExtrapConfig gains NearMissFraction and CRVNearMissFraction, both defaulting to 0.0 (disabled).
    • In Mu2eKinKal/fcl/prolog.fcl, LHDRIFTXTRAP, LHSEEDXTRAP, KLXTRAP and CHXTRAP set NearMissFraction : 0.1 and CRVNearMissFraction : 1e-3. These are starting values, pending optimization studies.
  • Output: the near miss is recorded as a KalIntersection with inbounds_ = false. Its kkinter_ carries pcov_ and inbfrac_, which estimate the probability that the track really passed through that material, for use in analysis.

2. CRV matching refactor (CRVReco, RecoDataProducts)

  • Removed from TrkCrvMatchTool: projectXing, the hand-built line projections onto the extended plane of a sector, and TrkCrvPlaneError.hh. The CRV crossings now come directly from the CRV KalIntersections: in-bounds crossings and near misses.
  • New helpers in TrkCrvGeom.hh:
    • trkCrvXingCovariance(ki, sector) takes the intersection's pcov_ and rotates it to the sector (u, v) axes. If the intersection has no covariance, it falls back to the plane covariance of the intersection's KinematicLine.
    • trkCrvPlaneCovariance(ki, sector, point, time) gives the line's covariance on a sector plane at a candidate point.
    • Both return 0 for a track (nearly) parallel to the plane, where trkCrvMinCosToNormal = 1e-3.
    • errorModel now takes a KinKal::PMAT.
  • Data product: TrkCrvXing gains float inbFrac_. It holds the intersection's inbfrac_ when that was computed, and otherwise 1 for in bounds and 0 for out of bounds. inBounds_ == false now means a near miss rather than a projection, and the field comments are updated. There is no ClassVersion, so no dictionary edit is needed. Older files should be analysed with an older release.

3. Downstream renames (CRVResponse, Validation)

  • TrkCrvMatchMCMaker:
    • Counters and summary columns for projections are renamed for near misses: recoProj → recoNear, recoProjTrue → recoNearTrue, trueMissedProj → trueMissedNear, and trueCluNoXing / chi2ndNoXing → trueCluNear / chi2ndNear.
    • The pull-diagnostic covariances use trkCrvPlaneCovariance.
    • Counters that describe a projection from another sector (trueCluProj, chi2ndProj) keep their names, since that step still exists.
  • Validation: ValTrkCrvMatch and ValTrkCrvMatchMC histograms are renamed from "Proj" to "Near" (for example RecoXingProj → RecoXingNear, NXingProj → NXingNear, chi2ndofProj → chi2ndofNear), with matching titles. Comparisons against reference files made before this PR will not match these histograms.

4. Tests

  • ExtrapolateSweepTest: a new near-miss section on a KinematicLine crossing a 50x50 mm rectangle (1 mm position sigma) checks:
    • that pcov_ is filled only when near misses are enabled;
    • accept/reject at fractions 0, 0.1 and 1e-3, with the expected inbfrac_ (for example 0.31 at 0.5 sigma outside the boundary);
    • rejection by the 5-sigma pre-screen;
    • that a group member after a near miss is still found, in both time directions;
    • that the near-miss material is inactive and leaves the trajectory unsplit, while an in-bounds crossing splits it.
  • Full build: the spack build with KinKal#239 succeeds.
  • Cosmic reco: Production/JobConfig/recoMC/Extracted.fcl (field-off extracted cosmics, KKLine) ran on 200 events with no errors.
    • Of 499 KKLine intersections, 61 are near misses, on the CRV sectors (EX/T1/T2, M1–M8) and the CRV strongback.
    • Their inbfrac_ values all respect the configured thresholds: 0.0018–0.49 on the CRV sectors and 0.11–0.46 on the strongback.
    • That job does not run TrkCrvMatcher, so the rewritten matching code has been compiled but not yet run on events.
  • Testing note: running the extracted-cosmic reco currently needs physics.producers.CosmicShowerFilter.ComboHitCollection : "makeSH". CosmicShowerFilter still reads makePH while SimpleTimeCluster uses makeSH. This is unrelated to this PR and will be fixed in a separate one.

— Claude (Opus 5.5, Anthropic), via Claude Code

…rajectory covariance in-bound fraction at the surface intersection. Add near-miss intersections to the KinKal payload. Refactor TrkCrvMatchToo to use 'near miss' instead of the by-hand edge testing. Coded by Claude.
@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @brownd1978,
You have proposed changes to files in these packages:

  • RecoDataProducts
  • Mu2eKinKal
  • CRVResponse
  • CRVReco
  • Validation

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for c4c53db: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

‼️ It was not possible to prepare the workspace for this test. This is often caused by merge conflicts - please check and try again.

> git diff --check | grep -i conflict
CRVReco/inc/TrkCrvMatchTool.hh:82: leftover conflict marker
CRVReco/inc/TrkCrvMatchTool.hh:85: leftover conflict marker
CRVReco/inc/TrkCrvMatchTool.hh:87: leftover conflict marker
Test Result Details
test with ✅ Command did not list any other PRs to include
merge ❌ c4c53db into 0f6b4ad merge failed

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #2204

Reviewed at head 49929928b238762be6b4bc0b80a1a64a44753895. First pass.

Decision

  • 🔴 request changes. Dave, the PR does not link with muse. libmu2e_CRVReco.so now calls KinKal trajectory code but does not link KinKal_Trajectory (finding 1). Three added lines fix it, and with them the merged tree builds with no warnings and runs.
  • Taking KinKal#239 also drops calorimeter material from a few tracks, through KKShellXing. This PR is the one that moves Offline to that KinKal, so this needs a fix, in KinKal or here, before it merges (finding 2).
  • The near-miss idea works. With both fractions at 0 the output is identical to main. With the defaults, fits do not change; KalSeeds gain many out-of-bounds IPA and stopping-target intersections, and the LoopHelix fits cost about 15% more CPU (finding 4). The TrkCrvMatcher change loses some matches, most of all on reconstruction files made before this PR (finding 3).
  • FNALbuild cannot build this yet: the envset KinKal does not have KinKal#239. Merge order: KinKal#239, then a KinKal tag at cb8107dc or later and an envset that carries it, then this PR. A tag at d426035c is not enough. This PR's ExtrapolateSweepTest checks that a near miss does not split the trajectory, and that needs the Material::extrapolate change in cb8107dc. I read this from the code; I did not build this PR against d426035c.
  • The head moved during my review, from c4c53dbf to 49929928 ("Merge main, resolve conflicts"). I had made the same merge myself, and the two trees are identical. Everything below was built and run on that tree.

Scope understood

  • A "near miss" is an out-of-bounds crossing where at least a set fraction of the projected position covariance lies inside the surface (inbfrac_ from KinKal#239). The sweep accepts it (ExtrapolateSweep.hh:459, test at :348-360), and KKExtrap adds it as an inactive material crossing (KKExtrap.hh:475). It does not use up its target or group (ExtrapolateSweep.hh:189-195).
  • NearMissFraction sets the fraction for IPA, stopping-target foils, DS shells, plane shells and calorimeter panels (KKExtrap.hh:197, :216, :261, :276, :309). CRVNearMissFraction sets it for CRV sectors (:290). Both default to 0 in C++ and are set to 0.1 and 1e-3 in all four extrapolation configurations in prolog.fcl:382-448.
  • TrkCrvMatcher drops its own projection of line fits with no CRV crossing. It uses the near-miss CRV intersections instead. TrkCrvXing gains float inbFrac_ (TrkCrvMatch.hh:56), and inBounds_ == false now means a near miss, not a projection (:55).
  • The covariance helper TrkCrvPlaneError.hh is deleted. TrkCrvGeom.hh:42-58 now uses KinKal's planeCovariance and the intersection's pcov_.
  • KKShellXing::updateReference asks for the projected covariance when the crossing has one (KKShellXing.hh:89).
  • Validation histograms are renamed from "Proj" to "Near".

Findings

  1. 🔴 [S0] The PR does not link with muse.
    • Evidence: muse build against KinKal cb8107dc stops at libmu2e_CRVReco.so:
      CRVReco/inc/TrkCrvGeom.hh:44: undefined reference to `KinKal::KinematicLine::planeCovariance(double, KinKal::Plane const&, double) const'
      RecoDataProducts/inc/KalIntersection.hh:42: undefined reference to `KinKal::KinematicLine::KinematicLine(KinKal::ParticleStateEstimate const&, ...)'
      
      The link line has -lKinKal_Geometry -lKinKal_General and no -lKinKal_Trajectory. muse links shared libraries with -Wl,--no-undefined, so this is an error. Same failure at c4c53dbf and on the merged tree.
    • Cause: TrkCrvGeom.hh:44 calls ki.kinematicLine().planeCovariance(...). CRVReco/src/SConscript:15-38 (library) and :40- (plugins) list only KinKal_Geometry and KinKal_General. TrkCrvMatchMCMaker_module.cc:463-464 makes the same call, and CRVResponse/src/SConscript:33-45 has the same list.
    • Fix: add 'KinKal_Trajectory', to both lists in CRVReco/src/SConscript and to the plugin list in CRVResponse/src/SConscript. For the CMake build, add KinKal::Trajectory next to KinKal::Geometry in CRVReco/CMakeLists.txt:15 and :52 and CRVResponse/CMakeLists.txt:158. With the three SConscript lines, the merged tree builds with no warnings. My patch: w_merge_cb8/local_link_patch.diff.
  2. 🟠 [S1] With KinKal#239, KKShellXing::updateReference switches off calorimeter material in some downstream tracks.
    • Code: the piece search at KKShellXing.hh:90 can now return an out-of-bounds crossing, and :93, :96 and :99 accept it on onsurface_ && inrange_. updateState then needs good() (:109), so the material is off. Before KinKal#239 that search returned nothing in the cases I reproduced with a toy, and the code went on to search the neighbouring piece. For the 5 tracks below I did not confirm the exact path.
    • Measured on Offline main with KinKal 3a6860b (this PR's KinKal base) against cb8107dc, 2,000 OnSpill events with SaveMaterialXings : true. 6 EMC_Disk_1_InnerRing crossings in 5 tracks go out of bounds, and their energy loss (1.2 to 9.3 MeV/c each) is dropped. That is 4 of 1,991 KKDe tracks and 1 of 1,955 KKDmu tracks. Momentum at EMC_Disk_1_Back moves by +1.5 to +10.5 MeV/c (event 3979: 86.93 to 97.42 MeV/c). The fits themselves do not change, because the ring is past the last hit. Details are in my KinKal#239 review.
    • I do not have a fix. Two local patches to updateReference did not work. Refusing to replace an in-bounds crossing with an out-of-bounds one keeps stale crossings and changes 30 fits. Retrying the ±1 ns trajectory search and preferring an in-bounds result leaves the same 5 tracks without the ring. Details and patches are in my KinKal#239 review.
    • Any fix here must apply only to crossings that were in bounds, because near misses are out of bounds by design.
  3. 🟡 [S2] TrkCrvMatcher loses some geometric matches, and loses all of the old projections on existing reconstruction files.
    • Measured on 10,000 CosmicCRYExtracted events (6,730 KKLine tracks), TrkCrvMatcher plus TrkCrvMatchMC as in my job (ProbeAllPulses : false, KalSeedCollection : "KKLine"):

      tracks with a geometric best ... that is the true cluster true clusters that are geometric candidates out-of-bounds crossings
      main 1,744 1,735 2,719 65 (projections)
      this PR, defaults 1,718 1,711 2,701 2,346 (near misses)
      this PR, both fractions 0 1,681 1,675 2,667 0
      this PR's matcher on a reco file made by main 1,681 1,675 2,667 0
    • With the defaults, 26 tracks lose their geometric best and none gain one. 24 of the 26 were true matches. Most are in CRV_EX: 49 true clusters were reached only through a projection in main, and 32 are reached through a near miss here. The TrkCrvMatchMC summary gives an average chi2/ndof of 19.3 for the 49 projection matches in main, and 5.3 for the 32 near-miss matches here. I did not check the chi2 of the 17 that are lost, so I cannot say how many would pass a chi2 cut.

    • Old files: a reco file made before this PR has no near-miss intersections. Running this matcher on it gives the "fractions 0" row: all 65 projections are gone, and 63 tracks lose their geometric best. EventNtuple runs TrkCrvMatcher when it makes ntuples from existing reco files (EventNtuple fcl/prolog.fcl:203-235). So ntuples from MDC2025 reco made with this Offline lose those matches.

    • Please decide whether this is wanted, and say it in the PR description. If the old files matter, one option is to keep the projection for line fits whose KalSeed has no CRV intersection at all.

  4. 🟡 [S2] Default production reconstruction gains many out-of-bounds intersections in every LoopHelix KalSeed, and costs more CPU.
    • Measured on 2,000 OnSpill events, merged tree with defaults against the same tree with both fractions 0. Fits are identical in every collection: status, active hits, chi2, t0, momentum. With both fractions 0 the output is identical to main built against the same KinKal.
    • New out-of-bounds intersections (inbounds_ false, dMom 0): KKDe +395 IPA and +8,233 stopping target, KKDmu +431 and +7,168, KKUe +745 and +5,552, KKUmu +652 and +6,280. For KKDe, the in-bounds stopping-target intersections are 21,725, so this adds 38%. Tracks with at least one out-of-bounds intersection go from 153 to 1,750 of 1,991 KKDe tracks.
    • Readers that do not check inbounds_ now count these. EventNtuple counts every IPA and stopping-target intersection in nipaup, nipadown, nstup and nstdown (src/InfoStructHelper.cc:110-121), and writes each intersection as a track segment. rooutil/inc/common_cuts.hh:80-90 (stopping_target_foils) selects segments by surface only. Offline Validation/src/ValKalSeed.cc:187-194 counts IPA and stopping-target intersections. SimpleKalSeedSelector takes the momentum from intersections().front() (TrkReco/src/SimpleKalSeedSelector_tool.cc:8), and KKFit::sampleFit puts IPA crossings first with no time sort (KKFit.hh:961, :1020). So a near miss can now be the intersection it reads.
    • CPU, same machine, the two jobs run side by side: the four LoopHelix fits go from 0.0905 to 0.1046 s/event (+15.6%; KKDe 0.0228 to 0.0264). The full event goes from 0.1548 to 0.1688 s (+9.0%). One run each. I did not split the cost. The new work is the covariance and bounds fraction for near-miss candidates and winners (ExtrapolateSweep.hh:348-360, :507), and bounded cylinders are no longer cut by z in withinReach when near misses are on (:179), as the comment there says. The KKLine fit in the cosmic job goes from 3.24 to 3.38 ms/event (+4.1%).
    • Output size: mcs.art +10,524,722 bytes for 2,000 OnSpill events (+1.8%, 5.3 kB/event). Cosmic job: mcs.art +0.27%, TrkCrvMatch file +0.84%.
    • Please say whether near misses should be on by default in production. If they are, the EventNtuple counters and the segment tables need an inbounds check, or a flag for near misses.
  5. 🟡 [S2] TrkCrvXing reads back fine both ways, but old and new data mean different things.
    • New code reading a TrkCrvMatch file made by main: no warnings, all fields match. inbFrac_ reads as 0 for all 3,293 in-bounds crossings, while the comment at TrkCrvMatch.hh:56 says it is 1 when not computed. The 65 old projections read as near misses (inBounds_ false).
    • Old code reading a file made by this PR: no warnings, all fields match, inbFrac_ is ignored. The 2,346 near misses look like projections. EventNtuple documents inbounds false as a projection (doc/branches.md:74, :79; utils/trkcrv_example.py:6-7, :84-86) and does not copy inbFrac_ (inc/TrkCrvXingInfo.hh).
    • Suggested: a ClassVersion bump with an I/O read rule that sets inbFrac_ from inBounds_ for old data, or change the comment to say old files give 0. An EventNtuple follow-up should update the docs and add inbfrac.
  6. ⚪ [S3] One of 7,822 tracks changes its in-bounds stopping-target crossings. Event 107, KKDmu: foil 15 is no longer crossed and foil 23 is, and the momentum at the foils moves by about 0.2 MeV/c. A possible cause: a near miss counts as a crossing in the KKExtrap loop (KKExtrap.hh:417-418), and each call to KinKal's extrapolate starts a new MaxDt window and new field domains from the current end. I did not trace this event.
  7. ⚪ [S3] NearMissFraction and CRVNearMissFraction in LHSEEDXTRAP (prolog.fcl:413-414) do nothing: that configuration has Upstream, ToCRV, ToOPA and the calorimeter targets off, so it has no target that uses them.
  8. ⚪ [S3] Validation histograms are renamed (NXingProj to NXingNear, chi2ndofProj, XingProjShield, RecoXingProj, RecoXingProjTrue, TrueXingProj, XingDistProj). valCompare between a release before and after this PR will show these as missing. Nothing in Offline, Production or EventNtuple reads them by name.

Checked, no action needed

  • 🟢 The merge conflict was mechanical. The only conflict was CRVReco/inc/TrkCrvMatchTool.hh: main commit 4914d1de3 (#2147) added void checkResolutions() const; next to errorModel, whose argument type this PR changes. 49929928 keeps both, as I did. Git auto-merged prolog.fcl (#2152 adds TS5_Face to SampleSurfaces), ExtrapolateSweep.hh (#2111 comment), KKExtrap.hh (#2111 range-out truncation, #2152) and TrkCrvMatchTool.cc (#2147). These do not interact with near misses: a near miss skips rangesOut (KKExtrap.hh !near && rangesOut), and TS5_Face is a sampled surface, not a sweep target.
  • 🟢 The covariance rotation in trkCrvXingCovariance (TrkCrvGeom.hh:50-58) is right. With rot(i,j) = axes[i]·idirs[j], Similarity(rot, pcov_) gives R C Rᵀ, the covariance in the sector axes, when the intersection plane is the sector plane. For CRV sectors the KinKal tangent plane is the rectangle itself, and TrkCrvGeom.cc:28-30 takes u, v, w from the same rectangle. The fallback builds Plane(g.w, g.u, point), whose V direction is w × u = g.v, so the sign of the U-V term is kept. It is the same straight-line projection as the deleted TrkCrvPlaneError.hh. Measured: with near misses off, all 1,681 tracks with a geometric best have the same sector and chi2 as main.
  • 🟢 KKShellXing and near misses: a near miss has no material at construction (KKShellXing.hh:75 needs good()), becomes active only if a refit moves it in bounds (:109), and does not split the trajectory (KinKal cb8107dc Material.hh:106-108). truncate ignores inactive effects, so near misses do not block the range-out truncation from #2111. In the OnSpill sample the in-bounds intersections are identical to main in every track except event 107 (finding 6).
  • 🟢 ExtrapolateSweepTest passes on the merged tree: "ExtrapolateSweepTest: all checks passed", 0.14 s, run against KinKal cb8107dc. It includes the new near-miss cases.

Validation check

  • Build/tests run: yes, with local changes, described here.
    • Merged tree (49929928) and c4c53dbf, muse p111, against KinKal cb8107dc installed locally: link failure (finding 1). With my three SConscript lines: the merged tree builds with no warnings.
    • Offline main 0f6b4ad0 against KinKal 3a6860b, d426035c and cb8107dc: all build with no warnings.
    • ExtrapolateSweepTest: passes.
    • Jobs: production recoMC/OnSpill.fcl on 2,000 events of dig.mu2e.CeMLeadingLogMix1BB.MDC2025au_best_v1_3.001430_00001612.art, and recoMC/Extracted.fcl plus TrkCrvMatcher, TrkCrvMatchMC and Validation on 10,000 events of dig.mu2e.CosmicCRYExtracted.MDC2025bb_best_v1_5.001400_00017143.art. Inputs read in place from dCache. Production at f1624445, mu2e-trig-config at 169df7db. All jobs exit 0 with no exceptions.
  • CI: read at 2026-11-21 23:25Z. At 49929928: mu2e/buildtest pending, "This test has not been triggered yet". At c4c53dbf: FNALbuild could not prepare the workspace because of the merge conflict. When it runs, it will fail to compile: the p111 envset KinKal has KinematicLine::planeCovariance(double, Plane const&) with no dirtol, and no inbfrac_.
  • Sourced numbers: NearMissFraction : 0.1 and CRVNearMissFraction : 1e-3 have no stated source. The PR description does not say how they were chosen.
  • Cross-repo consistency: needs a KinKal tag with KinKal#239 at cb8107dc or later, and an envset. EventNtuple needs follow-ups (findings 4 and 5).

Residual risk

  • One OnSpill file and one extracted cosmic file. I did not run upstream or off-spill cosmic samples, where CRV near misses on LoopHelix and CentralHelix fits would matter.
  • CPU numbers are from one run each on a shared machine.
  • I did not check the CentralHelix (CHXTRAP) fits or EventNtuple's own TrkCrvMatch configurations, which use other inputs.
  • I did not run Offline's validation suite or valCompare.

Author follow-ups

  1. Add KinKal_Trajectory to the CRVReco and CRVResponse link lists (finding 1).
  2. Resolve the calorimeter-material loss with KinKal#239 (finding 2), in KinKal or in KKShellXing, before this merges.
  3. Decide on the TrkCrvMatcher change for old files, and say it in the description (finding 3).
  4. Say whether near misses are on by default in production, and open EventNtuple issues for the counters, segment tables and inbFrac_ (findings 4 and 5).
  5. Fix the inbFrac_ comment or add a read rule (finding 5).
  6. After the KinKal tag and envset bump, update .muse and re-run FNALbuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants