Skip to content

p110 for kinkal 3.9.1 - #2100

Merged
brownd1978 merged 1 commit into
Mu2e:mainfrom
rlcee:p110
Nov 4, 2026
Merged

brownd1978 merged 1 commit into
Mu2e:mainfrom
rlcee:p110

Conversation

@rlcee

@rlcee rlcee commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Upate muse envset for new kinkal version, 3.9.1.
This changes the t0 value for some track fits, and saves more segments.

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @rlcee,
You have proposed changes to files in these packages:

  • /

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 7bccd29: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 7bccd29.

Test Result Details
test with ✅ Command did not list any other PRs to include
merge ✅ Merged 7bccd29 at 5629b9f
build (prof) ✅ Log file. Build time: 05 min 30 sec
ceSimReco ✅ Log file.
g4test_03MT ✅ Log file.
transportOnly ✅ Log file.
POT ✅ Log file.
g4study ✅ Log file.
cosmicSimReco ✅ Log file.
cosmicOffSpill ✅ Log file.
ceSteps ✅ Log file.
ceDigi ✅ Log file.
muDauSteps ✅ Log file.
ceMix ✅ Log file.
rootOverlaps ✅ Log file.
g4surfaceCheck ✅ Log file.
trigger ✅ Log file.
check_cmake ✅ Log file.
FIXME, TODO ✅ TODO (0) FIXME (0) in 0 files
clang-tidy ✅ 0 errors 0 warnings
whitespace check ✅ no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 7bccd29 after being merged into the base branch at 5629b9f.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Summary — #2100

Reviewed at head 7bccd295526d1ce40ca60773e5e05a91ad7b0b24. First pass.

Decision

  • 🟢 approve. Moving from p109 to p110 changes only KinKal, from v3.9.0 to v3.9.1; the other changed build, cry 1.7, is rebuilt from identical sources. FNALbuild built this head with p110, and every test passed. On the nightly reco_03 sample, the change in reconstruction output is exactly the one I measured for KFTrack/KinKal#231 before it merged. Offline#2084 is waiting for this envset, so this PR should merge first.

Scope understood

  • One line: .muse now says ENVSET p110 instead of p109.
  • The p109 and p110 envset files differ in two lines: the spack environment name, and KINKAL_VERSION (v03_09_00 becomes v03_09_01). The two spack environments list the same packages. Only two builds differ: KinKal, and cry 1.7 (see below). Art, ROOT, Geant4, gcc and artdaq-core-mu2e are the same builds.
  • KinKal v3.9.1 is v3.9.0 plus two merged PRs, in three headers (+41 −2):
    • KFTrack/KinKal#231: a fallback in PiecewiseTrajectory::t0() for when the search finds no self-consistent piece.
    • KFTrack/KinKal#232: Track::coverEndDomain, which extends the end piece to the outermost field domain before a field-corrected extrapolation.

Findings

  1. 🟡 [S2] The description does not say that p110 changes reconstruction output. On reco_03, most downstream fits save more segments, and several hundred report a different t0 and momentum (numbers below). Anyone who sees these shifts in validation after the merge will look for a cause. Please add one sentence, for example: "KinKal 3.9.1 changes which trajectory piece sets t0; most downstream KKDe/KKDmu fits save more segments, and a few report t0 up to 1.8 ns and momentum up to 2.4 MeV/c different."

Checked, no action needed

  • 🟢 FNALbuild build 3551 is a real p110 build. All 1,714 g++ lines in its scons.log write to build/al9-prof-e29-p110, and the log never mentions p109. Every row of the result table passed, including the eleven validation jobs, trigger, check_cmake, both overlap checks and clang-tidy.
  • 🟢 Reconstruction output, p109 against p110, on all 16,508 events of Production/Validation/nightly/reco_03.fcl with its two dig inputs.
    • Setup. The p109 run used the CI build of main 5629b9f2, which is this PR's merge base. For p110, I built this head with muse build, with the same Production (94a4d81f) and mu2e-trig-config (5999ffa2). The build finished with exit status 0 and no warnings. Every KalSeed collection was printed for every event. All 12 jobs exited with status 0, with no exceptions.
    • The same in both runs: the track count in every collection, every fit flag, fit consistency, hit and straw counts, and every crossing list except one track. All trigger collections, KKUmu, and every KKUe track but one are identical.
    • KKDe: 13,290 of 16,491 tracks save more segments (median 13 more, never fewer). 68 report a different momentum (at most 0.15 MeV/c), and 619 a different t0 (at most 0.4 ns).
    • KKDmu: 13,179 of 16,316 tracks save more segments (median 16 more, never fewer). 100 report a different momentum (2 by more than 1 MeV/c, at most 2.4 MeV/c), and 778 a different t0 (2 by more than 1 ns, at most 1.8 ns).
    • KKUe: one track, in event 1430:1652:852, saves 106 more segments and gains 4 calorimeter crossings. Its t0 of 531.7 ns now lies inside its range. This is the event behind Offline#2076.
    • Both runs are byte-identical, chunk by chunk, to the runs from my KinKal#231 review: v3.9.0, and #231 at 69375ef3, both on Offline 68b28d6e. So two things after that head change nothing on this sample: #231's last commit (iteration limit back to 10, simpler convergence test) and #232. Nor do the main changes since 68b28d6e. That review traced the cause. After a downstream fit is extrapolated upstream, its front piece is usually the reflected leg, whose t0 lies before the trajectory. The v3.9.0 search stops on that piece, and v3.9.1 converges on the tracker piece. KKFit::createSeed uses the direction at t0() to choose which tracker-boundary crossings bound the saved segments. So it now keeps the segments between TT_Front and the first hit.
  • 🟢 cry. p110 uses a different build of cry 1.7 (vlstp2b) from p109 (z6psfn5). It is the build that p107 and p108 used. diff -rq of the two install trees finds identical sources, headers and data files. The spack recipe differs only in its import line, and the library was rebuilt from the same sources.
  • 🟢 Nothing else needs a matching bump. No other in-scope repo pins an envset in a .muse file: Production, mu2e-trig-config, EventNtuple, PassN, EventDisplay, DQM and RefAna. The CMake path finds KinKal without a version (CMakeLists.txt:74).
  • 🟢 Merge order. Offline#2084 asks to merge "once a KinKal tag with KFTrack/KinKal#232 is in the envset" (its Dependency section). This PR provides that tag. No other open Offline PR touches .muse.

Validation check

  • Build/tests run: yes. I ran one full muse build of this head with p110, and the 16,508-event comparison above. I also ran a standalone t0() test against the p110 KinKal headers and libraries.
  • Config contract check: not applicable. The PR changes no fcl and no code.
  • Cross-repo consistency: pass.

Residual risk

  • In the released t0(), the closest-piece fallback runs only when the search ends outside the trajectory. Suppose the search cycles between two pieces and no piece is self-consistent. Then it returns what v3.9.0 returned.
    • In my standalone test, pieces with t0 values 1.5, 2.9, 1.1 and 4.3 on [0,4] give 1.1 with both v3.9.0 and v3.9.1. KinKal#231 at 69375ef3 gave 4.3.
    • On reco_03 the output matches 69375ef3 exactly, so this case either does not occur there or does not change the result. This is a question for KinKal, not for this PR.
  • Not checked:
    • Off-spill cosmics and CentralHelix fits with p110, beyond FNALbuild's cosmicOffSpill and cosmicSimReco jobs. My KinKal#232 review found the production KKCHmu setting (field correction off) unchanged by #232, but I did not rerun it with p110.
    • A CMake build of Offline with p110.

Author follow-ups

  1. Add one sentence to the description about the change in reconstruction output (finding 1).

@brownd1978
brownd1978 merged commit b24d416 into Mu2e:main Nov 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants