Skip to content

v11 node24 retry fix - #1

Merged
MrMarCode merged 3 commits into
mainfrom
MrMarCode/v11-node24-retry-fix
Sep 28, 2026
Merged

MrMarCode merged 3 commits into
mainfrom
MrMarCode/v11-node24-retry-fix

Conversation

@MrMarCode

Copy link
Copy Markdown
Owner

No description provided.

@MrMarCode

Copy link
Copy Markdown
Owner Author

Couple decisions made:

  1. I committed dist/source instead of uploading a build artifact. A git install would
    otherwise run the build on every install with unpinned build tools. The committed build
    of unmodified 11.8.6 matches the published npm got@11.8.6 exactly.
  2. The fix is upstream's got 16 fix (#2470),
    as backported in Kikobeats' fork (ac68c70, with its
    tests). I also ported his ECANCELED deferral from 4767219 by hand, so those requests
    are retried as they were on Node 24.19. I left out his other changes (write lock, cache),
    because they fix bugs that do not affect us.
  3. Some of got's own tests already fail on stock 11.8.6 under Node 24. They fail the same
    way with and without this change (no new failures), and they come from newer Node and
    OpenSSL. However, they don't affect runtime behavior we rely on so I'm not inclined to fix them.

@MrMarCode
MrMarCode force-pushed the MrMarCode/v11-node24-retry-fix branch from 8c79a55 to 9f54ef7 Compare September 28, 2026 18:23
@MrMarCode
MrMarCode merged commit f3a7182 into main Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant