Visual Studio crashes in most cases when opening Team Explorer

[doormalena]

Describe the bug
Visual Studio crashes sometimes when opening Team Explorer after just starting up Visual Studio.
My fellow team mates have the same behavior on their machines from time to time. Could it be performance related? When repeating the steps from the reproduction it will not crash after a few retries.

Eventlog shows .NET Runtime error:

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException
at Microsoft.VisualStudio.Shell.ThreadHelper.get_JoinableTaskContext()
at vs_commitizen.vs2015.VsCommitizenNavigationItem+d__4.MoveNext()
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(System.Threading.Tasks.Task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(System.Threading.Tasks.Task)
at vs_commitizen.vs2015.VsCommitizenNavigationItem+<GitService_PropertyChanged>d__3.MoveNext()
at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.b__6_1(System.Object)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(System.Object)
at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

To Reproduce
Steps to reproduce the behavior:

1. Start Visual Studio
2. Open Recent project (in this case hosted on Azure DevOps / Git-repo)
3. Click Connect in the (authentication) dialog that is opening up.

Expected behavior
No crash.

Screenshots
If applicable, add screenshots to help explain your problem.

Visual Studio (please complete the following information):

• Professional or Enterprise (same behavior)
• 2019 / 16.2.3

[MrLuje]

Ah, never ran into that one...

Could it be performance related?

Yep, could be... since most VS Package logic should be async, I guess I'm trying to access non-ready UI stuff at this point (even I am properly awaiting the UI thread with ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync() 😩)

I'll have a look

[MrLuje]

You can give a try to this version

[doormalena]

Thanks for your effort!
Just tested it. VS keeps crashing unfortunately.

[MrLuje]

one more

Do you have other extensions, beside this one, in common with your teammate that impacts "Team Explorer" view ?

[doormalena]

This version seems promising. It did not make VS crash after first startup. I will continue to do some startup tests today.

In regards to your question: yes we have multiple other extensions installed which we have in common:

• R#
• PowerShell Tools for Visual Studio
• ReAttach
• Visual Studio Spell Checker (VS2017 and Later)
• HSR Parallel Checker for C#
• Productivity Power Tools 2017/2019

Whether they are impacting the Team Explorer view I don't know at this time.

[doormalena]

Strange. First 2 tests where OK. Now it constantly crashes again.

[MrLuje]

Ok, new one : it should prevent any crashing and will instead log the error in output panes

[doormalena]

I does not make much of a difference, it keeps crashing with the same error. I cannot see the output pane as well, am I missing something?

[MrLuje]

If this one doesn't prevent the crash, I'll probably need a crash dump to have more insights about it

[doormalena]

I have a crash dump for you unfortunately.

[bvirkler]

I'm getting the same crashes. (Love this extension otherwise!)

[aguacongas]

Same crash after commited the code using VS 2019 16.5.4. The stack trace is a little bit different :

Application: devenv.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.FileNotFoundException
   at vs_commitizen.vs2015.VsCommitizenNavigationItem.UpdateIsVisibleAsync()
   at vs_commitizen.vs2015.VsCommitizenNavigationItem+<GitService_PropertyChanged>d__3.MoveNext()
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__6_1(System.Object)
   at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(System.Object)
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

[MrLuje]

The "System.IO.FileNotFoundException" bug is fixed in the new release (but I don't think it will address the original issue)