Repository navigation
refactor(rng): drop the always-default replacement parameter from ManagerRng.choice - #2626
Merged
Merged
Conversation
…agerRng.choice ManagerRng.choice only ever supported sampling with replacement (replacement=False raised NotImplementedError from the API's introduction), so the parameter misled callers into discovering the limitation at runtime. The narrower signature makes the with-replacement-only contract explicit and removes the NotImplementedError guard plus its test assertion. No in-repo or known downstream caller passed the argument. Follow-up to #2624, building on #2625.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManagerRng.choicedrops thereplacementparameter. Sampling was always with replacement —replacement=FalseraisedNotImplementedErrorfrom the API's introduction (2026-09-30,19a5160b) — so the parameter was a false promise that pushed discovery of the limitation to runtime.NotImplementedErrorguard, the parameter, and the matching test assertion intests/managers/test_rng.py. The docstring now states "sampling is always with replacement" explicitly.TypeError: unexpected keyword argument, the same failure surface as any unsupported kwarg.Linked Work
mainValidation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run:
Impact
Artifacts
Checklist